[pgAdmin4][Patch] - SonarQube Issues - 13 (String literals should not be duplicated)

Hi, Please find patch which fixes 15 issues related to rule from feature test modules - 1.String literals should not be duplicated Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 diff --git a/web/pgadmin/feature_tests/pg_datatype_validation_test.py b/web/pgadmin/f

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Index Constraint: - Refactor this function to reduce its Cognitive Complexity from 31 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 41 to the 15

Re: pgAdmin 4 commit: Ensure that the original file format should be retain

Hi Yogesh, I see one problem with the given solution, if a user opens two files from two different locations with the same name but with different encoding then the backend dict mapper (filename -> encoding) will be overridden by the later filename. -- Regards, Murtuza Zabuawala *EDB* *POWER TO

Code coverage report generation for JS files

Hi Team, As recent updates have added ability to generate code coverage report for all the JS files. Where had added two new packages as below: istanbul-instrumenter-loader karma-coverage Steps to generate report: Apply attached patch Do - ‘npm install’ Run – ‘yarn run test:karma’ It

Bug #4387 - User can not insert any value on view data if table and column name contains *SELECT '<alert("XSS ");//<';*

Hello, Please find patch which fixes 2 issues reported in Bug #4387 1.Incorrect Column name when column name is like *'SELECT '

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Wed, Aug 5, 2020 at 12:41 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Schema Domains and Domain Constraints: > >- Refactor this function to r

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a406f466db6b0f0f5c6dead520072e316ccface Author: Nikhil Mohite Modified Files -- .../servers/databases/schemas/domains/__init

Re: [pgAdmin4 ] Limit the scope of CSS

Thanks, patch applied. On Tue, Aug 4, 2020 at 4:27 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA small patch to fix the `.dashboard-graph-body` CSS class scope to > prevent it affecting other places. > > -- > Regards, > Murtuza Zabuawala > *EDB* > *POWER TO POSTG

Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

Thanks, patch applied. On Wed, Aug 5, 2020 at 11:09 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to replace the generic exception class with a newly > added ExecuteError class for all the places where error occurs when a SQL > is executed

pgAdmin 4 commit: Change the scope of '.dashboard-graph-body' CSS class

Change the scope of '.dashboard-graph-body' CSS class to prevent it from affecting other places. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2621282dce4efa3a4bc47e17e7b1e0ecdc7a884 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Replace the generic exception class with a more speci

Replace the generic exception class with a more specific one to fix SonarQube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa679e06b27cf036d6906fdfd201b26368b10e80 Author: Aditya Toshniwal Modified Files -- .../databas

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Schema Domains and Domain Constraints: - Refactor this function to reduce its Cognitive Complexity from 34 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity