Re: WIP: SQL Formatter

2020-08-17 Thread Aditya Toshniwal
Hi Dave, The patch looks good to me except pep8 issues. In the below SQL - BEGIN, RETURN, END are not formatted. But when only the BEGIN line is selected and the format button is clicked then it gets formatted. This seems to be a bug in sqlparse. Create or replace Function public.simple_func(i_var

Re: WIP: SQL Formatter

2020-08-17 Thread Akshay Joshi
Hi Aditya Can you please review it On Mon, Aug 10, 2020 at 11:11 AM Akshay Joshi wrote: > Hi Aditya > > Can you please review and test. > > On Fri, Aug 7, 2020 at 9:28 PM Dave Page wrote: > >> >> >> On Mon, Aug 3, 2020 at 10:51 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote:

pgAdmin4 v4.25 candidate builds

2020-08-17 Thread Akshay Joshi
Hi All, pgAdmin4 v4.25 candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-08-17-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres *

Re: pgAdmin 4 - Czech translation update for 4.25

2020-08-17 Thread Akshay Joshi
Thanks, patch applied. On Mon, Aug 17, 2020 at 5:49 PM Libor M. wrote: > Hi, > updated Czech translation for 4.25 is in attachment. > > Best regards, > > Libor M. > > E-mail: libor...@gmail.com > GitHub: https://github.com/liborm85 > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr.

pgAdmin 4 commit: Update Czech translation.

2020-08-17 Thread Akshay Joshi
Update Czech translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f73516f8c9a5cc4c79809db04aba88a7808bd8a Author: Libor M Modified Files -- .../translations/cs/LC_MESSAGES/messages.mo| Bin 178709 -> 193620 bytes

Re: [pgAdmin4][Patch] - Fixed Schema Diff UI issue for the identical objects

2020-08-17 Thread Akshay Joshi
Thanks, patch applied. On Mon, Aug 17, 2020 at 2:54 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the Schema Diff UI issue. > While selecting the identical object, the Javascript console gives an > error which is fixed in this patch. >

pgAdmin 4 commit: Update Dependencies.

2020-08-17 Thread Akshay Joshi
Update Dependencies. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=085a4f4abf82bd21b142608b8e16032117f9 Modified Files -- DEPENDENCIES | 225 +-- 1 file changed, 128 inse

pgAdmin 4 commit: Fixed feature test failure due to updating font-aweso

2020-08-17 Thread Akshay Joshi
Fixed feature test failure due to updating font-awesome from v4 to v5. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0122cf9aacf94291d962bd88db6b66210db68b16 Author: Yogesh Mahajan Modified Files -- web/regression/feature_utils/

Re: [pgAdmin4][Patch] - Feature Test Failures (Locator change fix)

2020-08-17 Thread Akshay Joshi
Thanks, patch applied. On Mon, Aug 17, 2020 at 12:23 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes change in locator due to 'Updating font > awesome font version' > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone:

pgAdmin 4 commit: Fixed an issue where the entire logs is in red text w

2020-08-17 Thread Akshay Joshi
Fixed an issue where the entire logs is in red text when the user runs backup and restore. Fixes #5604 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0af385ea0f13d279109e0c1e737878ec06efc89 Modified Files -- docs/en_US/release_n

pgAdmin 4 commit: Fixed schema diff issue when selecting any identical

2020-08-17 Thread Akshay Joshi
Fixed schema diff issue when selecting any identical node. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae18b9a0ac7534d83a6e873a9b0d677ba2b08431 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/schema_diff/static/js/s

pgAdmin 4 commit: Update version for release.

2020-08-17 Thread Akshay Joshi
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3b1ef0b80138ad7837637fdd3c32ed30e3a3894 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

[pgAdmin4][Patch] - Fixed Schema Diff UI issue for the identical objects

2020-08-17 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the Schema Diff UI issue. While selecting the identical object, the Javascript console gives an error which is fixed in this patch. Thanks, Khushboo schema_diff_ui.patch Description: Binary data