pgAdmin4 - help adding new node to Browser Tree

2020-09-01 Thread Warren Chan
Hi, I'm trying to learn about the pgAdmin4 project and am hoping to make some contributions sometime in the future. I'm new to Flask and python but am keen to learn. While trying to familiarize myself with the application and the way it works, I've tried to create a 'test' node under the schema

pgAdmin 4 commit: Modified 'cryptography' version to less than or equal

2020-09-01 Thread Akshay Joshi
Modified 'cryptography' version to less than or equal to 3.0 to fix the pgAdmin4 launch issue on Windows. Cryptography's new version may be creating a problem. This is a temporary fix and will have to investigate the proper fix. Branch -- master Details --- https://git.postgresql.org/git

[pgAdmin][SonarQube] Reduce cognitive complexity

2020-09-01 Thread Aditya Toshniwal
Hi Hackers, Attached patch reduces cognitive complexity as below: web/.../server_groups/servers/pgagent/__init__.py - 23 to 15 web/pgadmin/utils/driver/psycopg2/__init__.py - 23 to 15, 17 to 15 web/setup.py 77 to 15 Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engin

Re: More idiomatic python3 + fix some tests

2020-09-01 Thread Murtuza Zabuawala
Hi, On Tue, Sep 1, 2020 at 2:36 PM Cyril Jouve wrote: > thanks :) > > and sure, I'll run the linter next time! > > have you thought of automatic code formatters instead like yapf or black? > AFAIK, yapf is not consistent with formatting & black is non-configurable. I tried both sometime back an

Re: More idiomatic python3 + fix some tests

2020-09-01 Thread Cyril Jouve
thanks :) and sure, I'll run the linter next time! have you thought of automatic code formatters instead like yapf or black? Le lun. 31 août 2020 à 13:18, Akshay Joshi a écrit : > Hi Cyril > > Thanks, patch applied. Please make sure to run "yarn run pep8" before > sending the patch. > > On S

pgAdmin 4 commit: Fix typo

2020-09-01 Thread Dave Page
Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b85831fb5f6afee60903d5c0fa057a6e6f1fe6e5 Modified Files -- pkg/linux/setup-web.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin] Accessibility fixes for main panels

2020-09-01 Thread Akshay Joshi
Thanks, patch applied. On Tue, Sep 1, 2020 at 12:04 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to fix the accessibility errors found with > WAVE tool on > >- Dashboard >- Dependencies / Dependents panel with no object selec

pgAdmin 4 commit: Fixed accessibility issues for main panels.

2020-09-01 Thread Akshay Joshi
Fixed accessibility issues for main panels. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd0ed81f7f4550361471f783b1494a0178b7325e Author: Ganesh Jaybhay Modified Files -- web/pgadmin/browser/templates/browser/index.html