Re: Quick search for menu items & help articles

Hi Dave, Thank you for comments ! I had described points below. Please do let me know if anything missing. From: Dave Page Date: Thursday, 14 January 2021 at 10:26 PM To: Pramod Ahire Cc: pgadmin-hackers Subject: Re: Quick search for menu items & help articles Hi On Thu, Jan 14,

Re: Quick search for menu items & help articles

Hi Pramod Following are the review comments: - linter issue "Undefined variable $black" - In Desktop mode remove the separator beside the search icon. On Thu, Jan 14, 2021 at 10:18 PM Pramod Ahire wrote: > Hi Team, > > > > Please find the attached designs & patch that contains complete

[pgAdmin][RM-6122]: There is no informative message when there is no diff found

Hi Team, Please find the attached patch for RM-6122 : There is no informative message when there is no diff found. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* RM

Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

Thanks, patch applied. On Thu, Jan 14, 2021 at 5:58 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch, updated UI to allow users to select an > older date for the account expires. > > > Regards, > Nikhil Mohite. > > On Thu, Jan 14, 2021 at 2:

pgAdmin 4 commit: Ensure that the user should be able to specify an old

Ensure that the user should be able to specify an older date for the account expiration of the role/user. Fixes #6120 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2edf317a9ce02c16058feb229c3228a03cf145a Author: Nikhil Mohite Modified Fil

RE: Is there a mistake in line 22 of Make.bat?

Thanks for your answer. -- Thanks & Regards HuangJ From: Dave Page Sent: Thursday, January 14, 2021 5:15 PM To: Huang, Jun/黄 军 Cc: pgadmin-hack...@postgresql.org Subject: Re: Is there a mistake in line 22 of Make.bat? Hi On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun mailto:huangj.f...@cn.fujits

Re: Quick search for menu items & help articles

Hi On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire wrote: > Hi Team, > > > > Please find the attached designs & patch that contains complete > functionality except below to do for quick search. > > > > To Do: > > > >- Unit test cases are not that sufficient to cover complete code, but >will

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

FYI, I did a quick test (and browse of PyPI): - On Windows, it seems there is a binary wheel available: (gssapi) C:\Users\dpage>pip install gssapi Collecting gssapi Downloading gssapi-1.6.12-cp39-cp39-win_amd64.whl (670 kB) || 670 kB 3.3 MB/s Collecting deco

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi Khushboo, As you know, this has been rolled back as the buildfarm blew up. I think there are a number of TODOs that need to be addressed, given that the gssapi Python module is dependent on MIT Kerberos: In the patch: - Linux packages will need the additional dependencies to be declared in th

Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

Hi Akshay, Please find the updated patch, updated UI to allow users to select an older date for the account expires. Regards, Nikhil Mohite. On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi wrote: > Hi Nikhil > > On Thu, Jan 14, 2021 at 2:38 PM Dave Page wrote: > >> >> >> On Thu, Jan 14, 2021 at

Re: [pgAdmin][RM5912]: Added support for Logical Replication.

Hi Pradip The patch is applied, but not working. Please check and send the patch again. On Wed, Jan 13, 2021 at 9:08 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please ignore my previous patch. Please find my updated patch. > > > On Mon, Jan 11, 2021 at 5:07 PM P

Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

Hi Nikhil On Thu, Jan 14, 2021 at 2:38 PM Dave Page wrote: > > > On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Team, >>>

pgAdmin 4 commit: Revert "1) Added support for Kerberos authentication,

Revert "1) Added support for Kerberos authentication, using SPNEGO to forward  the Kerberos tickets through a browser. Fixes #5457" This reverts commit 6ead597b434cb9ff9f8500c49a5c68bf9e52ab2a. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f

pgAdmin 4 commit: Revert "Ensure that the account expiration date for r

Revert "Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120" This reverts commit 9a47e574e315ebc5d2721d69718edb72bcc91b5a. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f86f58dc562a862fd2a

Re: Is there a mistake in line 22 of Make.bat?

Hi On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun wrote: > Hi, > > The following code is line 22 of Make.bat: > if "%Platform%" == "X86" ( > > I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the > result is "x86"(not "X86"). > If it's a mistake, the attached patch adds t

Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> Please find the attached patch for RM-6120 >> : Adding/updatin

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Thanks, patch applied. On Thu, Jan 14, 2021 at 1:42 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please ignore my previous patch, attached the updated one. > > Thanks, > Khushboo > > On Thu, Jan 14, 2021 at 12:17 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrot

Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

Thanks, patch applied. On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6120 > : Adding/updating user should > not allow to add an older date in account expires.

pgAdmin 4 commit: Ensure that the account expiration date for role/user

Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a47e574e315ebc5d2721d69718edb72bcc91b5a Author: Nikhil Mohite Modified Files ---

pgAdmin 4 commit: 1) Added support for Kerberos authentication, using S

1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi, Please ignore my previous patch, attached the updated one. Thanks, Khushboo On Thu, Jan 14, 2021 at 12:17 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Thu, Jan 14, 2021 at 12:00 PM Akshay Joshi <