Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab

2021-02-08 Thread Akshay Joshi
Hi Aditya Please fix the issue for Dashboard API calls as well and send the patch again. On Mon, Feb 8, 2021 at 5:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The changes for not calling the ajax until the panel is focused were > missed in the last patch. Please r

Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab

2021-02-08 Thread Aditya Toshniwal
Hi, The changes for not calling the ajax until the panel is focused were missed in the last patch. Please review the attached. On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> w

Re: [pgAdmin4][Patch] - Feature Tests Failure Fix

2021-02-08 Thread Akshay Joshi
Thanks, patch applied. On Mon, Feb 8, 2021 at 3:04 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Mon, Feb 8, 2021 at 2:36 PM Akshay Joshi > wrote: > >> Hi Yogesh >> >> Please fix the PEP8

pgAdmin 4 commit: Fixed feature test failures.

2021-02-08 Thread Akshay Joshi
Fixed feature test failures. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9089750e21e83978b8c96f46b699099dc9cdf0b9 Author: Yogesh Mahajan Modified Files -- web/regression/feature_utils/tree_area_locators.py | 16 ++-

pgAdmin 4 commit: Handle the new Rust dependency in the Python Cryptogr

2021-02-08 Thread Dave Page
Handle the new Rust dependency in the Python Cryptography module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f9a29f66377daf40bab82290ff7b0724db5dbd5 Modified Files -- pkg/mac/build-functions.sh | 10 +- 1 file changed,

pgAdmin 4 commit: Update Docker container build to handle the new Rust

2021-02-08 Thread Dave Page
Update Docker container build to handle the new Rust requirement in thePython Cryptography module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=447a1c9dd765399ec427201ac0495da9858a44c3 Modified Files -- Dockerfile | 14

Re: [pgAdmin4][Patch] - Feature Tests Failure Fix

2021-02-08 Thread Yogesh Mahajan
Hi, Please find the updated patch. Thanks, Yogesh Mahajan EnterpriseDB On Mon, Feb 8, 2021 at 2:36 PM Akshay Joshi wrote: > Hi Yogesh > > Please fix the PEP8 issues and send the patch again. > > On Mon, Feb 8, 2021 at 1:54 PM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hel

Re: pgagent unicode support

2021-02-08 Thread Dave Page
Hi On Sat, Feb 6, 2021 at 5:00 AM Sergey Burladyan wrote: > Currently pgagent doesn't handle unicode correctly. > > CharToWString function corrupt multibyte characters because it processes > string one byte at a time: > 148 std::string s = std::string(cstr); > 149 std::wstring

Re: [pgAdmin4][Patch] - Feature Tests Failure Fix

2021-02-08 Thread Akshay Joshi
Hi Yogesh Please fix the PEP8 issues and send the patch again. On Mon, Feb 8, 2021 at 1:54 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find a patch which fixes feature tests failures that occurred due > to new feature logical replication. > > > Thanks, > Yoges

[pgAdmin4][Patch] - Feature Tests Failure Fix

2021-02-08 Thread Yogesh Mahajan
Hello, Please find a patch which fixes feature tests failures that occurred due to new feature logical replication. Thanks, Yogesh Mahajan EnterpriseDB Feature_Tests_Fix_v1.0 Description: Binary data