Neel Patel writes:
> Thanks for the review. Please find the attached updated patch.
> Do review it and let me know in case of any comments.
Looks good, thanks!
--
Sergey Burladyan
Hi Sergey,
Thanks for the review. Please find the attached updated patch.
Do review it and let me know in case of any comments.
Thanks,
Neel Patel
On Wed, Feb 24, 2021 at 5:12 PM Sergey Burladyan
wrote:
> Sergey Burladyan writes:
>
> > Maybe it should look something like this:
> > +wc
Sergey Burladyan writes:
> Maybe it should look something like this:
> +wcstombs_s(&charsConverted, mbs, mb_len + 1, wchar_str, mb_len);
Ah, and we missed check for error.
Something like this, maybe:
+#ifdef __WIN32__
+size_t charsConverted = 0;
+if (wcstombs_s(&charsCon
Neel Patel writes:
> Do you have any comments for this updated patch ? Let us know ASAP so that
> we can commit it.
Sorry about the delay.
It looks better than my patch, thanks!
There is only two comments, about wcstombs_s and about setlocale.
About win32 wcstombs_s:
+wcstombs_s(&char
