Re: Feature Test Fix

2021-03-31 Thread Yogesh Mahajan
Hello, Please find one more patch which rename nomenclature for video & log file names created by solenoid. Thanks, Yogesh Mahajan EnterpriseDB On Thu, Apr 1, 2021 at 12:19 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Apr 1, 2021 at 12:06 PM Yogesh Mahajan < > yogesh.maha...@en

Re: Feature Test Fix

2021-03-31 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 1, 2021 at 12:06 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Team, > > Please find a patch which asserts the actual result of button click > (before it did not). > Also changes in locators for query tool & vire/edit data are accommodated. >

pgAdmin 4 commit: Fixed feature tests.

2021-03-31 Thread Akshay Joshi
Fixed feature tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27bb7d8c7a3d3b994ffb8879f5960ccb61afffaa Author: Yogesh Mahajan Modified Files -- web/pgadmin/feature_tests/browser_tool_bar_test.py | 15 +-- web/reg

Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.

2021-03-31 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 1, 2021 at 11:40 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the updated patch with the change mentioned by Dave. > > On Wed, Mar 31, 2021 at 7:53 PM Dave Page wrote: > >> Thanks Pradip. >> >> Before this is committ

pgAdmin 4 commit: Ensure that the query tool tab should be closed after

2021-03-31 Thread Akshay Joshi
Ensure that the query tool tab should be closed after server disconnection when auto-commit/auto-rollback is set to false. Fixes #5519 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=566f03becaebccb06ffa54e0bf8d4ce6908a02df Author: Pradip Park

Feature Test Fix

2021-03-31 Thread Yogesh Mahajan
Hi Team, Please find a patch which asserts the actual result of button click (before it did not). Also changes in locators for query tool & vire/edit data are accommodated. Thanks, Yogesh Mahajan EnterpriseDB Feature_Tests_Fix_v3.0.patch Description: Binary data

Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.

2021-03-31 Thread Pradip Parkale
Hi Hackers, Please find the updated patch with the change mentioned by Dave. On Wed, Mar 31, 2021 at 7:53 PM Dave Page wrote: > Thanks Pradip. > > Before this is committed, let's change this: > > gettext('Current trasaction is not commited because server is > disconnected.'), > > to: > > gettex

Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.

2021-03-31 Thread Dave Page
Thanks Pradip. Before this is committed, let's change this: gettext('Current trasaction is not commited because server is disconnected.'), to: gettext('The current transaction has been rolled back because the server was disconnected.'), On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale < pradip.p

[pgAdmin][RM5519]: Unable to close tab after disconnecting server.

2021-03-31 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #5519. Updated the existing confirmation message and also added a new confirmation dialog before closing the query tool if the server is disconnected. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5519.patch Des

Re: CLI for Schema Diff

2021-03-31 Thread Dave Page
Hi On Tue, Mar 30, 2021 at 3:36 PM Steve Chavez wrote: > Hey all, > > In case anyone is interested, I've managed to enable a CLI mode for the > Schema Diff on this repo: > > https://github.com/steve-chavez/pgadmin4/blob/cli/web/cli.py > > It basically works by using a Flask test client that inte