Re: pgAdmin 4 - add missing gettexts and text space improvements

Thanks, the patch applied. On Wed, Jun 23, 2021 at 7:20 PM Libor M. wrote: > Hi, > I added some missing gettext usage and improved spaces in texts. > Diff file is attached. > > Best regards, > > Libor M. > > E-mail: libor...@gmail.com > GitHub: https://github.com/liborm85 > -- *Thanks & Regar

Re: Refactor: Registry Classes

Thanks, the patch applied. On Wed, Jun 23, 2021 at 7:54 PM Ashesh Vashi wrote: > On Wed, Jun 23, 2021 at 1:22 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Ashesh >> >> Following are the review comments: >> >>- Fixed PEP8 issues. >> >> Done. > >> >>- In "dynamic_regis

pgAdmin 4 commit: Refactor the registry class logic and remove duplicat

Refactor the registry class logic and remove duplicate code for the same functionality. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9574f43f87ebb64f00e5c209d877cac529aa525f Author: Ashesh Vashi Modified Files -- web/pgadmin/a

pgAdmin 4 commit: Fixed Czech translation string for 'Login' keyword. F

Fixed Czech translation string for 'Login' keyword. Fixes #6555 Patch sent by: Waclaw Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a53be65ab04aa1545c6d8f4397458f570b840866 Modified Files -- docs/en_US/release_notes_5_5.rst

pgAdmin 4 commit: Added missing gettexts and text space improvements.

Added missing gettexts and text space improvements. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc989c5c0857d371a362b2aa8a1fa7c3714a9f78 Author: Libor M Modified Files -- .../servers/databases/subscriptions/static/js/subscript

Re: Refactor: Registry Classes

On Wed, Jun 23, 2021 at 1:22 PM Akshay Joshi wrote: > Hi Ashesh > > Following are the review comments: > >- Fixed PEP8 issues. > > Done. > >- In "dynamic_registry/__init__.py" decorator @classmethod used for " >*_get*" and "*_load_modules*" methods which are actually outside of >

pgAdmin 4 - add missing gettexts and text space improvements

Hi, I added some missing gettext usage and improved spaces in texts. Diff file is attached. Best regards, Libor M. E-mail: libor...@gmail.com GitHub: https://github.com/liborm85 diff --git a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js b/web/pgad

pgAdmin 4 commit: Ensure that Data Output panel can be snapped back aft

Ensure that Data Output panel can be snapped back after it is detached. Fixes #4189 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=313224e6f5d12d8e8ba1395503e37577ffeea73b Author: Nikhil Mohite Modified Files -- docs/en_US/relea

Re: Refactor: Registry Classes

Hi Ashesh Following are the review comments: - Fixed PEP8 issues. - In "dynamic_registry/__init__.py" decorator @classmethod used for " *_get*" and "*_load_modules*" methods which are actually outside of the class. Even constructor also outside of the class. - Remove unused imports

Re: [pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

Thanks, the patch applied. On Tue, Jun 22, 2021 at 4:17 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > Please ignore my previous email and find the attached patch. I have fixed > some review comments given by Aditya. > > On Tue, Jun 22, 2021 at 2:21 PM Fred wrote: >

Re: [pgAdmin][RM-6505]: Changing connection using the Drop Down has lost default "maintenance" database auto-select functionality and tab-through functionality.

Thanks, the patch applied. On Tue, Jun 22, 2021 at 5:28 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6505 > : Changing connection using > the Drop Down has lost default "maintenance"

pgAdmin 4 commit: Fixed an issue in the search object when searching in

Fixed an issue in the search object when searching in 'all types' or 'subscription' if the user doesn't have access to the subscription. Fixes #6448 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80ccd62d384192a76b8d4b10b3853fcbc6ee2123 Autho

pgAdmin 4 commit: Fixed replace keyboard shortcut issue in the query to

Fixed replace keyboard shortcut issue in the query tool on the normal keyboard layout. Fixes #6388 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b81ff45d34bdf3cc7935060071eac55ad77741ab Author: Aditya Toshniwal Modified Files -

pgAdmin 4 commit: Fixed an issue where the New Connection Drop Down has

Fixed an issue where the New Connection Drop Down has lost default maintenance database, auto-select, and tab-through functionality. Fixes #6505 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2adb29ffc092c16a0b8459f04518b07886b666ce Author: N

pgAdmin 4 commit: Do not block the query editor window when running a q

Do not block the query editor window when running a query. Fixes #3920 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81b78dd2b25a8ad524bea32a053a8e0f95410f08 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_5_