Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react

2021-08-25 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Aug 26, 2021 at 11:53 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch. I have improved the code coverage of > Function node and also fixed the test cases which were failing for Cast > ,Subscription and

Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react

2021-08-25 Thread Pradip Parkale
Hi Akshay, Please find the attached patch. I have improved the code coverage of Function node and also fixed the test cases which were failing for Cast ,Subscription and Publication node. On Tue, Aug 24, 2021 at 10:54 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > >

Re: [pgAdmin][RM6419] pgAdmin blank screen issue on windows

2021-08-25 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Aug 25, 2021 at 5:34 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the blank screen issue on windows. I was able to > reproduce this on my Windows 10 VM. > I've also made changes to use NWjs manifest inste

pgAdmin 4 commit: Fixed blank screen issue on windows and also made cha

2021-08-25 Thread Akshay Joshi
Fixed blank screen issue on windows and also made changes to use NWjs manifest  for remembering window size. Fixes #6419 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=092f830c3c454900f2dd9502033031023330eaef Author: Aditya Toshniwal Modifie

[pgAdmin][RM6419] pgAdmin blank screen issue on windows

2021-08-25 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the blank screen issue on windows. I was able to reproduce this on my Windows 10 VM. I've also made changes to use NWjs manifest instead of our pgadmin config json for remembering window sizes. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Soft

Re: [pgAdmin][RM4629] Show DB and server information on maintenance process watcher

2021-08-25 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Aug 25, 2021 at 12:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes failing RE-SQL test cases. > > On Wed, Aug 25, 2021 at 11:15 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the p

Re: [pgAdmin][RM-6685]: Deleting a database automatically selects (and opens) the next database

2021-08-25 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Aug 25, 2021 at 12:13 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6685 > : Deleting a database > automatically selects (and opens) the next database

pgAdmin 4 commit: Fixed RESQL test cases.

2021-08-25 Thread Akshay Joshi
Fixed RESQL test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c543930ac476a3e51b4a56457d5498560054ee8d Author: Aditya Toshniwal Modified Files -- .../tables/triggers/tests/pg/default/create_plain_trigger_function.sql |

pgAdmin 4 commit: Ensure that deleting a database should not automatica

2021-08-25 Thread Akshay Joshi
Ensure that deleting a database should not automatically connect to the next database. Fixes #6685 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b30a42ab9e4d221191403c79745fcfc4025e28dc Author: Nikhil Mohite Modified Files -- d

Re: [pgAdmin][RM4629] Show DB and server information on maintenance process watcher

2021-08-25 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes failing RE-SQL test cases. On Wed, Aug 25, 2021 at 11:15 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Aug 25, 2021 at 10:44 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please ignore the previous pat