Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 10:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch. > > On Wed, Sep 22, 2021 at 7:15 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Patch not applied, please rebase and se

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-22 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 12:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > 😓 Attached is the patch. > > On Thu, Sep 23, 2021 at 11:58 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> You need a coffee, forgot to attach

pgAdmin 4 commit: Fixed an issue where the Properties panel was not loa

2021-09-22 Thread Akshay Joshi
Fixed an issue where the Properties panel was not loaded for catalog tables. Fixes #6778 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=78c8fbbe0026e71f123d381c51af417be35b66c4 Author: Aditya Toshniwal Modified Files -- .../sche

pgAdmin 4 commit: Fixed API test case.

2021-09-22 Thread Akshay Joshi
Fixed API test case. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25c98f805434425600c9d42bf1cdbd5121c9f958 Modified Files -- .../databases/schemas/tables/tests/table_test_data.json| 10 +- 1 file changed, 5 insert

pgAdmin 4 commit: Pin material-ui to 4.11 as later versions have some p

2021-09-22 Thread Akshay Joshi
Pin material-ui to 4.11 as later versions have some problems. Test cases are also failing on the latest material-ui version. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d681d68d764b49090e587ccfaa60ce5827e60b6 Author: Aditya Toshniwal Mo

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-22 Thread Aditya Toshniwal
😓 Attached is the patch. On Thu, Sep 23, 2021 at 11:58 AM Akshay Joshi wrote: > Hi Aditya > > You need a coffee, forgot to attach the patch again :) > > On Thu, Sep 23, 2021 at 11:38 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch will pin

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-22 Thread Akshay Joshi
Hi Aditya You need a coffee, forgot to attach the patch again :) On Thu, Sep 23, 2021 at 11:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will pin material-ui to 4.11 as later versions have some > breaking changes. Test cases are also failing

[pgAdmin][patch] Pin material-ui to v4.11

2021-09-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch will pin material-ui to 4.11 as later versions have some breaking changes. Test cases are also failing because of the latest version. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Comp

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Aditya Toshniwal
Hi, Attached is the updated patch. On Wed, Sep 22, 2021 at 7:15 PM Akshay Joshi wrote: > Patch not applied, please rebase and send again. > > On Wed, Sep 22, 2021 at 7:00 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Not again. Attached is the patch. :D >> >> On Wed, Se

Re: [pgAdmin][RM-6781]: Incorrect privileges value in MView.

2021-09-22 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 22, 2021 at 4:53 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6781 > : Incorrect privileges value > in MView. > > -- > *Thanks & Regards,* > *Ni

Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

2021-09-22 Thread Akshay Joshi
Thanks, the patch applied with some modifications. Changed the variable names. On Wed, Sep 22, 2021 at 4:44 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > > On Mon, Sep 20, 2021 at 8:13 PM Akshay Joshi < > akshay.jo...@enterprisedb.com>

Re: [pgAdmin][RM6766] Unable to change column properties from edit properties dialogue

2021-09-22 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 22, 2021 at 12:52 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes all the column edit related bugs. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Software Architect | *edbpostgr

Re: [pgAdmin][RM6770] Foreign Key multiple fixes

2021-09-22 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Sep 22, 2021 at 11:50 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1. Auto FK related fixes. > 2. Properties tab not showing columns. > 3. Toggle button is editable even if set to readonly. > 4. Dropdo

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Akshay Joshi
Patch not applied, please rebase and send again. On Wed, Sep 22, 2021 at 7:00 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Not again. Attached is the patch. :D > > On Wed, Sep 22, 2021 at 6:47 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Can you please attac

pgAdmin 4 commit: Added flag to check before adding 'IF NOT EXISTS' and

2021-09-22 Thread Akshay Joshi
Added flag to check before adding 'IF NOT EXISTS' and 'OR REPLACE' clause to the SQL. While creating any object the respective clause should not be added. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f192be36670510009c21aa589ac76014fb8cf14c

pgAdmin 4 commit: Foreign Key fixes:

2021-09-22 Thread Akshay Joshi
Foreign Key fixes: 1. Auto FK related fixes. 2. Properties tab not showing columns. 3. Toggle button is editable even if set to read-only. 4. Dropdown placeholder should be blank for read-only/disabled. 5. Input control help text color on a dark theme. Fixes #6770 Branch -- master Details --

pgAdmin 4 commit: Fixed incorrect privileges value in Materialize View.

2021-09-22 Thread Akshay Joshi
Fixed incorrect privileges value in Materialize View. Fixes #6781 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05ce3445b521ea770709d4f24a4412340971d13c Author: Nikhil Mohite Modified Files -- .../server_groups/servers/databases

pgAdmin 4 commit: Fixed an issue where unable to change the column prop

2021-09-22 Thread Akshay Joshi
Fixed an issue where unable to change the column properties from edit dialog. Fixes #6766 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1aa0809563bfb46f1dfe8ab143f79adeec5345a Author: Aditya Toshniwal Modified Files -- .../sch

pgAdmin 4 commit: Changed the layout for tables from block layout to fl

2021-09-22 Thread Akshay Joshi
Changed the layout for tables from block layout to flex layout to fix the width of the columns as per the dialog size. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc86faf51e81b63a1fa2073f9235cc3bcdca78d3 Author: Aditya Toshniwal Modified

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Aditya Toshniwal
Not again. Attached is the patch. :D On Wed, Sep 22, 2021 at 6:47 PM Akshay Joshi wrote: > Can you please attached the patch :) > > On Wed, Sep 22, 2021 at 6:40 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch fixes issue where properties pa

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Akshay Joshi
Can you please attached the patch :) On Wed, Sep 22, 2021 at 6:40 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes issue where properties panel is not loaded for > catalog tables. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin

[pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes issue where properties panel is not loaded for catalog tables. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE"

[pgAdmin][RM-6781]: Incorrect privileges value in MView.

2021-09-22 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6781 : Incorrect privileges value in MView. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* RM-6781.patch Descript

pgAdmin 4 commit: Fixed validation issue in Synonyms dialog. Fixes #676

2021-09-22 Thread Akshay Joshi
Fixed validation issue in Synonyms dialog. Fixes #6767 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f538546c4de7cb2c8da07cfb703ad199da7a436c Modified Files -- .../servers/databases/schemas/synonyms/static/js/synonym.ui.js

pgAdmin 4 commit: Remove unused files.

2021-09-22 Thread Akshay Joshi
Remove unused files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71d7b143202ab492eb6b8251169dec5912871fba Modified Files -- web/pgadmin/static/js/browser/index.js | 2 - .../static/js/browser/server_groups/index.js

[pgAdmin][RM6766] Unable to change column properties from edit properties dialogue

2021-09-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes all the column edit related bugs. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM6766.patch Description: Binary data