Re: [pgAdmin][RM6741]: Cast node issues

2021-09-23 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 6:00 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > Please find the attached for following issues: > >1. Function should be empty by default. >2. System cast? should be True for system cast. >3. Explicit s

Re: [pgAdmin][RM-6792]: Few options missing in trigger function >> Security.

2021-09-23 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 6:28 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for > RM-6792: > [React] Few options missing >

Re: [pgAdmin][RM6771] Exclusion Constraint Node fixes

2021-09-23 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 6:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1. Incorrect error message. > 2. Properties panel Column Section data missing > 3. Operator class value is missing > Please review. > >

pgAdmin 4 commit: Fixed an issue where options are missing in the trigg

2021-09-23 Thread Akshay Joshi
Fixed an issue where options are missing in the trigger function's Security tab. Fixes #6792 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6dce27ffa621a523b5b0d83041168a28332da99 Author: Nikhil Mohite Modified Files -- .../fun

pgAdmin 4 commit: Fixed Cast node related issues. Fixes #6741

2021-09-23 Thread Akshay Joshi
Fixed Cast node related issues. Fixes #6741 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d08d9aa9fa3a40405f7b2a6774c58a66b59f7b2 Author: Pradip Parkale Modified Files -- .../browser/server_groups/servers/databases/casts/__init

pgAdmin 4 commit: Fixed exclusion constraint issues:

2021-09-23 Thread Akshay Joshi
Fixed exclusion constraint issues: 1. Incorrect error message. 2. Properties panel Column Section data missing 3. Operator class value is missing Fixes #6771 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d28f8bc7ee2ee13d4037f6a2c5060d88c

[pgAdmin][RM6771] Exclusion Constraint Node fixes

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Incorrect error message. 2. Properties panel Column Section data missing 3. Operator class value is missing Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat

[pgAdmin][RM-6792]: Few options missing in trigger function >> Security.

2021-09-23 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6792: [React] Few options missing in trigger function >> Security. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres*

[pgAdmin][RM6741]: Cast node issues

2021-09-23 Thread Pradip Parkale
Hi Hackers, Please find the attached for following issues: 1. Function should be empty by default. 2. System cast? should be True for system cast. 3. Explicit should be selected by default. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6741.patch

pgAdmin 4 commit: Fixed linter error.

2021-09-23 Thread Akshay Joshi
Fixed linter error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=812532009398e1457df852e7f51516a5c3062f41 Modified Files -- web/pgadmin/static/js/components/PgTable.jsx | 15 +-- 1 file changed, 1 insertion(+), 14 del

pgAdmin 4 commit: Fixed scrollbar issue and used flex layout in grant w

2021-09-23 Thread Akshay Joshi
Fixed scrollbar issue and used flex layout in grant wizard. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecaaa8a1b55f4c974b739fffdebe401f5e9aab39 Modified Files -- web/pgadmin/browser/static/css/wizard.css| 1 + web/pgadm

pgAdmin 4 commit: 1. Placeholder should be inside the controlProps. Cha

2021-09-23 Thread Akshay Joshi
1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...' 2. Updated grant wizard screenshot and documentation. 3. Remove '(Beta)' from ERD Tool and PSQL Tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4

Re: [pgAdmin][RM6777] Deferrable, deferred, included columns fields are editable in Edit Table > Constraint tab

2021-09-23 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 1:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1. Unique constraint should not allow changing values for deferrable , > deferred, included columns. > 2. Primary keys should not allow

Re: [pgAdmin][RM6772] Modified SQL not loading Unique Constraint dialog

2021-09-23 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 2:09 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes issue where modified SQL not loading Unique > Constraint dialog. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | S

pgAdmin 4 commit: Fixed issue where modified SQL not loading Unique Con

2021-09-23 Thread Akshay Joshi
Fixed issue where modified SQL not loading Unique Constraint dialog. Fixes #6772 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e6794f2f59afb6f94e4face2530c9460ecc8a03 Author: Aditya Toshniwal Modified Files -- .../constraints/i

pgAdmin 4 commit: Fixed review comments for Grant Wizard.

2021-09-23 Thread Akshay Joshi
Fixed review comments for Grant Wizard. refs #6687 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15a494c18926b09780e044e2ddca0b6b0136c662 Author: Nikhil Mohite Modified Files -- web/pgadmin/browser/static/js/table.jsx

pgAdmin 4 commit: Fixed following issues after React Porting:

2021-09-23 Thread Akshay Joshi
Fixed following issues after React Porting: 1. Unique constraint should not allow changing values for deferrable, deferred, included columns. 2. Primary keys should not allow changing values for deferrable, deferred, included columns. 3. Foreign keys should not allow changing match type. The ref

[pgAdmin][RM6772] Modified SQL not loading Unique Constraint dialog

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes issue where modified SQL not loading Unique Constraint dialog. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM6772.patch Description: Binary

[pgAdmin][RM6777] Deferrable, deferred, included columns fields are editable in Edit Table > Constraint tab

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Unique constraint should not allow changing values for deferrable , deferred, included columns. 2. Primary keys should not allow changing values for deferrable , deferred, included columns. 3. Foreign keys should not allow changing match type. Referenced table

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-23 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 23, 2021 at 12:59 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please pin @material-ui/lab to 4.0.0-alpha.58 also. Attached is the patch. > > On Thu, Sep 23, 2021 at 12:15 PM Akshay Joshi < > akshay.jo...@enterprisedb.com

pgAdmin 4 commit: Pin @material-ui/lab to 4.0.0-alpha.58, to fix build

2021-09-23 Thread Akshay Joshi
Pin @material-ui/lab to 4.0.0-alpha.58, to fix build on Windows x64 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19f01817569ea0e19f71a1d70302620c5ca57016 Author: Aditya Toshniwal Modified Files -- web/package.json | 2 +- web/ya

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Please pin @material-ui/lab to 4.0.0-alpha.58 also. Attached is the patch. On Thu, Sep 23, 2021 at 12:15 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Sep 23, 2021 at 12:08 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> 😓 Attached is the pat