Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Akshay Joshi
On Thu, Jun 9, 2022 at 2:27 PM Dave Page wrote: > > > On Thu, 9 Jun 2022 at 09:47, Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi >> wrote: >> >>> >>> >>> On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: >>> On Thu,

Re: [pgAdmin][RM-7453]: DB restriction does not work

2022-06-09 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Jun 9, 2022 at 2:32 PM Nikhil Mohite wrote: > Hi Hackers, > > Please find attached the patch for RM-7453 > : DB restriction does not work > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Senior Software Engineer.*

pgAdmin 4 commit: Fixed an issue where the Database restriction is not

2022-06-09 Thread Akshay Joshi
Fixed an issue where the Database restriction is not working. Fixes #7453 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd1f71587ff2cba89865d35176506ef91bd7fa5a Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_6_

Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-09 Thread Akshay Joshi
Hi Nikhil Following are the review comments: *GUI:* - *Parameter dialog*: - Get the warning when parameter dialog gets opened Warning: [JSS] Could not find the referenced rule "disabled" in "makeStyles". - Debug button should not be enabled until all the required param

[pgAdmin][RM-7453]: DB restriction does not work

2022-06-09 Thread Nikhil Mohite
Hi Hackers, Please find attached the patch for RM-7453 : DB restriction does not work -- *Thanks & Regards,* *Nikhil Mohite* *Senior Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* RM-7453.patch Descripti

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Dave Page
On Thu, 9 Jun 2022 at 09:47, Pradip Parkale wrote: > > > On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi > wrote: > >> >> >> On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: >> >>> >>> >>> On Thu, 9 Jun 2022 at 08:16, Akshay Joshi >>> wrote: >>> Hi Pradip Following are the review comme

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Pradip Parkale
On Thu, Jun 9, 2022, 2:06 PM Akshay Joshi wrote: > > > On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: > >> >> >> On Thu, 9 Jun 2022 at 08:16, Akshay Joshi >> wrote: >> >>> Hi Pradip >>> >>> Following are the review comments: >>> >>> >>>- 'show user defined templates' in preferences should

Re: [pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments

2022-06-09 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Jun 9, 2022 at 11:53 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Wed, Jun 8, 2022 at 3:56 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Please fix the pep8, linter, and jasmine te

pgAdmin 4 commit: Fixed some cloud deployment issues:

2022-06-09 Thread Akshay Joshi
Fixed some cloud deployment issues: - Added High Availability option - Server group renamed to pgAdmin server group - Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin. Branch -- master Details --- https://git.postgresql.

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Akshay Joshi
On Thu, Jun 9, 2022 at 1:25 PM Dave Page wrote: > > > On Thu, 9 Jun 2022 at 08:16, Akshay Joshi > wrote: > >> Hi Pradip >> >> Following are the review comments: >> >> >>- 'show user defined templates' in preferences should be ''show user >>defined template databases'. >> >> Is it just us

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Dave Page
On Thu, 9 Jun 2022 at 08:16, Akshay Joshi wrote: > Hi Pradip > > Following are the review comments: > > >- 'show user defined templates' in preferences should be ''show user >defined template databases'. > > Is it just user defined ones, or does it include template0/template1? > >- >

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-09 Thread Akshay Joshi
Hi Pradip Following are the review comments: - 'show user defined templates' in preferences should be ''show user defined template databases'. - Help message for 'Template?' should be changed to "Note: When the preferences setting 'show user defined templates' is set to false, then