Re: [pgAdmin][RM-6132]: [React] Port debugger to React

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 14, 2022 at 6:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch v2, fixed all review comments. > > On Thu, Jun 9, 2022 at 4:53 PM Akshay Joshi > wrote: > >> Hi Nikhil >> >> Following are the review comments: >> >> *GUI:

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Jun 15, 2022 at 9:52 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 14, 2022 at 6:26 PM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hello, >> >> Please find the updated patch which validates the field after the

pgAdmin 4 commit: Added capability to deploy PostgreSQL servers on Micr

2022-06-14 Thread Akshay Joshi
Added capability to deploy PostgreSQL servers on Microsoft Azure. Fixes #7178 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e1e0683701c10ece8870d02e6c1eb44fb06edd5 Author: Yogesh Mahajan Modified Files -- docs/en_US/cloud_azure

pgAdmin 4 commit: 1) Added mouse over indication for breakpoint area in

2022-06-14 Thread Akshay Joshi
1) Added mouse over indication for breakpoint area in the Debugger. Fixes #2647 2) Added search text option to the Debugger panel. Fixes #2648 3) Port Debugger to React. Fixes #6132 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2adca6bbc46843

Re: [Patch] - Feature #7332 - pgadmin docker container doesn't work properly with secrets

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 14, 2022 at 3:32 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch with documentation updates. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Tue, Jun 14, 2022 at 1:09 PM Dave Page wrote: > >> >> >> On

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jun 14, 2022 at 6:03 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch for resql test cases failure. > > > *Thanks & Regards,* > > *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* > > > On Mon

Re: [pgAdmin4][Patch]: BigAnimal High Availability Fix

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Jun 15, 2022 at 9:26 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > While deploying the instance into the cloud, if the High Availability > option is not selected, it will throw a backend error. Please find the > attached patch to fix it.

Re: [pgAdmin][RM-7453]: DB restriction does not work

2022-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Jun 15, 2022 at 10:42 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch resolved issue DB restriction check was not working for > collection node. > > On Thu, Jun 9, 2022 at 5:04 PM Akshay Joshi > wrote: > >> Thanks, the patch

pgAdmin 4 commit: Added support for passing password using Docker Secre

2022-06-14 Thread Akshay Joshi
Added support for passing password using Docker Secret to Docker images. Fixes #7332 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3297546e0a85493ccb1900a3805048da89047bfc Author: Yogesh Mahajan Modified Files -- docs/en_US/con

pgAdmin 4 commit: Fixed RESQL test cases introduced after Template patc

2022-06-14 Thread Akshay Joshi
Fixed RESQL test cases introduced after Template patch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbf7b4aec303b495b9c1fee2c4d1bd8e14040456 Author: Pradip Parkale Modified Files -- web/pgadmin/browser/server_groups/servers/da

pgAdmin 4 commit: Fixed an issue when deploying instances on BigAnimal

2022-06-14 Thread Akshay Joshi
Fixed an issue when deploying instances on BigAnimal with the High Availability option not selected, it throws an error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48336fd7f4b408900709cac433f3c155da0dc54e Author: Khushboo Vashi Modified

pgAdmin 4 commit: Fixed an issue where the DB restriction check was not

2022-06-14 Thread Akshay Joshi
Fixed an issue where the DB restriction check was not working for the collection node. Fixes #7453 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99c7a50fd6a932d6204e67efb5067ec5ce082e73 Author: Nikhil Mohite Modified Files -- .

Re: [pgAdmin][RM-7453]: DB restriction does not work

2022-06-14 Thread Nikhil Mohite
Hi Akshay, PFA patch resolved issue DB restriction check was not working for collection node. On Thu, Jun 9, 2022 at 5:04 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Jun 9, 2022 at 2:32 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-14 Thread Khushboo Vashi
On Tue, Jun 14, 2022 at 6:26 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find the updated patch which validates the field after the blur > event on cluster name. > > Looks good to me. Thanks. Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Tue, Jun 14, 2022 at

[pgAdmin4][Patch]: BigAnimal High Availability Fix

2022-06-14 Thread Khushboo Vashi
Hi, While deploying the instance into the cloud, if the High Availability option is not selected, it will throw a backend error. Please find the attached patch to fix it. Thanks, Khushboo biganimal_high_avail_fix.patch Description: Binary data

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-14 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for resql test cases failure. *Thanks & Regards,* *Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation* On Mon, Jun 13, 2022 at 6:21 PM Akshay Joshi wrote: > Hi Pradip > > The fix is not correct as it is still failing for PG and PPAS. Please

Re: [Patch] - Feature #7332 - pgadmin docker container doesn't work properly with secrets

2022-06-14 Thread Yogesh Mahajan
Hi, Please find the updated patch with documentation updates. Thanks, Yogesh Mahajan EnterpriseDB On Tue, Jun 14, 2022 at 1:09 PM Dave Page wrote: > > > On Tue, 14 Jun 2022 at 07:05, Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hello Team, >> >> Please find the attached pat

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-14 Thread Khushboo Vashi
On Tue, 14 Jun 2022, 13:29 Yogesh Mahajan, wrote: > Hi Khushboo, > > Thanks for reviewing the patch. > > On Tue, Jun 14, 2022 at 11:35 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yogesh, >> >>- Spelling mistake in below error message >> - Name must be more than

Re: [Patch] - Feature #7332 - pgadmin docker container doesn't work properly with secrets

2022-06-14 Thread Dave Page
On Tue, 14 Jun 2022 at 07:05, Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello Team, > > Please find the attached patch which enabled pgAdmin docker image to pass > password using docker secret. > Nice! Seems like it’s missing the corresponding doc update though. > -- -- Dave Pa