Re: [Patch] - Cursor is not visible in trigger code pane

2022-08-22 Thread Aditya Toshniwal
Hi, The patch LGTM. On Mon, Aug 22, 2022 at 6:49 PM Akshay Joshi wrote: > Aditya, > > Can you please review this? > > On Mon, Aug 22, 2022 at 6:46 PM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hello, >> >> Please find the attached patch which fixes the problem of >> non-vis

Re: [pgAdmin][RM-7633]: On startup, autofocus on master password input.

2022-08-22 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Aug 22, 2022 at 5:37 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch to fix failing test case. > > > On Mon, Aug 22, 2022 at 4:01 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >>

Re: [Patch] - Cursor is not visible in trigger code pane

2022-08-22 Thread Akshay Joshi
Aditya, Can you please review this? On Mon, Aug 22, 2022 at 6:46 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find the attached patch which fixes the problem of > non-visibility of the cursor in the code tab of trigger functions. > > > Thanks, > Yogesh Mahajan

pgAdmin 4 commit: Fixed Jasmine test cases.

2022-08-22 Thread Akshay Joshi
Fixed Jasmine test cases. refs #7633 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b6efd1c4d5b01f4d42ad8d6a0925cb00ae05875 Author: Nikhil Mohite Modified Files -- web/regression/javascript/SchemaView/SchemaView.spec.js | 3 ++-

[Patch] - Cursor is not visible in trigger code pane

2022-08-22 Thread Yogesh Mahajan
Hello, Please find the attached patch which fixes the problem of non-visibility of the cursor in the code tab of trigger functions. Thanks, Yogesh Mahajan EnterpriseDB CursorNotVisibleInTriggerCodePane_v1.patch Description: Binary data

Re: [pgAdmin][RM-7633]: On startup, autofocus on master password input.

2022-08-22 Thread Nikhil Mohite
Hi Akshay, PFA patch to fix failing test case. On Mon, Aug 22, 2022 at 4:01 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Aug 22, 2022 at 3:47 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find attached the patch for RM-7633 : On st

pgAdmin4 v6.13 candidate builds

2022-08-22 Thread Akshay Joshi
Hi All, pgAdmin4 v6.13 candidate builds and source code is available at https://developer.pgadmin.org/builds/2022-08-22-1/ Fahar, could you please verify this for Thursday's release? -- Akshay Joshi Principal Software Architect +91 9767888246 www.enterprisedb.

Re: [pgAdmin][RM-7633]: On startup, autofocus on master password input.

2022-08-22 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Aug 22, 2022 at 3:47 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached the patch for RM-7633 : On startup, autofocus on > master password input. > This patch also included a fix for xss issue in register server dial

Re: Security Bug on pgadmin 4 6.12

2022-08-22 Thread Akshay Joshi
On Mon, Aug 22, 2022 at 3:30 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Thank you for reporting this. We will fix this before the next release. > > Please report it here - > https://redmine.postgresql.org/projects/pgadmin4/issues/new > We have committed the fix. > > > O

pgAdmin 4 commit: 1) Ensure that the autofocus is on the input control

2022-08-22 Thread Akshay Joshi
1) Ensure that the autofocus is on the input control for the master password and server password dialogs. Fixes #7633 2) Fixed an XSS vulnerability in the Hostname/Address control in the Server Connection dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.

pgAdmin 4 commit: Update version for release.

2022-08-22 Thread Akshay Joshi
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d53f2b69f28066a43cd319493d2d978001808868 Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[pgAdmin][RM-7633]: On startup, autofocus on master password input.

2022-08-22 Thread Nikhil Mohite
Hi Hackers, Please find attached the patch for RM-7633 : On startup, autofocus on master password input. This patch also included a fix for xss issue in register server dialog. -- *Thanks & Regards,* *Nikhil Mohite* *Senior Software Engineer.* *EDB Postgres* *Mob

Re: Security Bug on pgadmin 4 6.12

2022-08-22 Thread Aditya Toshniwal
Thank you for reporting this. We will fix this before the next release. Please report it here - https://redmine.postgresql.org/projects/pgadmin4/issues/new On Mon, Aug 22, 2022 at 3:03 PM Khoa Bùi Đức Anh wrote: > Hi team I found a XSS vulnerabillity on the latest pgAdmin4 (6.12). > > Step by

Security Bug on pgadmin 4 6.12

2022-08-22 Thread Khoa Bùi Đức Anh
Hi team I found a XSS vulnerabillity on the latest pgAdmin4 (6.12). Step by step Bug is at API /browser/server/obj/7/ Object -> Register -> Server -> Connection Fill in Hostname/address value ss"> Click save, XSS fired Anymore information, you can ask me Thanks khoabda

Re: [pgAdmin][RM7579] Multiple query tool fixes

2022-08-22 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Aug 22, 2022 at 1:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1. Copy paste with rows null data sets default value to null for boolean. > Fixes #7579 > 2. White page error on query history. Fixes #

Re: [Patch] - Bug #7632 - [Azure PostgreSQL] - Unable to authenticate using Azure CLI on Mac

2022-08-22 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Aug 22, 2022 at 12:39 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find the attached patch which fixes the problem of not > including azure cli installation path in the PATH variable of the runtime > environment. > I have added

pgAdmin 4 commit: 1. Fixed an issue where copy and pasting a row in the

2022-08-22 Thread Akshay Joshi
1. Fixed an issue where copy and pasting a row in the results grid doesn't set the default for boolean. Fixes #7579 2. Fixed an issue where the History tab is getting blank and showing an error after some queries are executed. Fixes #7468 3. Fixed query tool view data crash. Branch -- master

pgAdmin 4 commit: Fixed an issue where a user could not authenticate us

2022-08-22 Thread Akshay Joshi
Fixed an issue where a user could not authenticate using Azure CLI on OSX. Fixes #7632 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2de89dcaaf2973a7bf10048ae68197276347c24f Author: Yogesh Mahajan Modified Files -- docs/en_US/r

[pgAdmin][RM7579] Multiple query tool fixes

2022-08-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Copy paste with rows null data sets default value to null for boolean. Fixes #7579 2. White page error on query history. Fixes #7468 3. Query tool view data crash. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.

[Patch] - Bug #7632 - [Azure PostgreSQL] - Unable to authenticate using Azure CLI on Mac

2022-08-22 Thread Yogesh Mahajan
Hello, Please find the attached patch which fixes the problem of not including azure cli installation path in the PATH variable of the runtime environment. I have added explicitly '/usr/local/bin' location to the PATH variable while spawning the pgAdmin 4 runtime process. Kindly let me know if the