Re: [pgAdmin][patch]: sonarQube bug fixes

Thanks, the patch was applied. On Fri, Sep 9, 2022 at 6:30 PM Nikhil Mohite wrote: > Hi Hackers, > > Please ignore the previous patch, PFA updated patch. > > On Fri, Sep 9, 2022 at 6:17 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find attached the pa

Re: Sonarqube fixes v2

Thanks, the patch was applied. On Fri, Sep 9, 2022 at 7:24 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch which fixes issue related to rule - > > 1.Use concise character class syntax > 2.Add a "break" statement or remove this "else" clause. >

Re: Sonarqube fixes

Thanks, the patch was applied. On Sat, Sep 10, 2022 at 12:25 AM Pravesh Sharma < pravesh.sha...@enterprisedb.com> wrote: > Hi, > > Attached patch contains sonarqube fix for rule ternary operators > should not be nested. > > Thanks, > Pravesh > > -- > > > > Pravesh Sh

Re: [pgAdmin][patch] Sonarqube bug fixes

Thanks, the patch was applied. On Sat, Sep 10, 2022 at 12:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attach patch fixes multiple sonarqube bugs. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Software Architect | *edbpostgres.com*

Re: [pgAdmin4][Patch]: Remove Backgrid & Backform

Thanks, the patch was applied. On Fri, Sep 9, 2022 at 8:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached rebased patch. > > Thanks, > Khushboo > > On Fri, Sep 9, 2022 at 5:51 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >>

pgAdmin 4 commit: Fixed the following code smells:

Fixed the following code smells: 1. Use concise character class syntax 2. Add a "break" statement or remove this "else" clause. 3. Replace this generic exception class with a more specific one. 4. Use a regular expression literal instead of the 'RegExp' constructor. 5. Use the opposite operator ("n

pgAdmin 4 commit: Fixed a couple of SonarQube issues.

Fixed a couple of SonarQube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b128ba2f57393c1402a963e745acf69101916723 Author: Aditya Toshniwal Modified Files -- .../server_groups/servers/static/js/server.ui.js | 2 +- we

pgAdmin 4 commit: Fixed 'ternary operators should not be nested' code s

Fixed 'ternary operators should not be nested' code smell. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43022b7aa2a4516499dda318eba8ede0a59e4443 Author: Pravesh Sharma Modified Files -- web/pgadmin/browser/static/js/browser.js

pgAdmin 4 commit: Remove Backgrid and Backform. Fixes #6134

Remove Backgrid and Backform. Fixes #6134 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca8b5c68fd8ded513dab3e5c99135acfced8ca2d Author: Khushboo Vashi Modified Files -- docs/en_US/code_overview.rst |2

pgAdmin 4 commit: Fixed 'Remove the unused function parameter' code sme

Fixed 'Remove the unused function parameter' code smell. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d967d5046dd3e334d6694c627aac068bed1108c9 Author: Nikhil Mohite Modified Files -- web/pgadmin/__init__.py