Re: PgAdmin-System_stats extension Patch

2022-09-15 Thread Khushboo Vashi
Hello Kunal, Please find the review comments as below: User Interface: - The Thread count graph missing the details of handle count and thread count plotting (lines), I can only see the legends. - The graph details (below the graphs) are not aligned properly. - The Disk graph is showing nothing a

Translators: Release next week

2022-09-15 Thread Akshay Joshi
Hi Translators, We will have a release next week, so updates to translations before the release would be helpful. The template and catalogs have been updated in git. *Note:* We generally create our candidate builds on Monday (2 PM IST), so please send the translation file by Monday 1.00 PM IST.

pgAdmin 4 commit: Update message catalogs.

2022-09-15 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a87c07df9349fe196c4efab181c333ebaac08209 Modified Files -- web/pgadmin/messages.pot | 5165 ++-- .../translations/cs/LC_MESSA

Re: [Patch] - Bug #7472 - The message "EDB Big Animal authentication process is in progress" is displayed on the Big Animal credentials screen if the user closes the URL with the crossbar without auth

2022-09-15 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 15, 2022 at 5:41 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello Team, > > Please find the attached patch which fixes 2 issues below - > 1.Bug #7472 - The message "EDB Big Animal authentication process is in > progress" is displayed on th

pgAdmin 4 commit: 1) Fixed the error message displayed when clicking th

2022-09-15 Thread Akshay Joshi
1) Fixed the error message displayed when clicking the cloud server for which deployment is in progress. Fixes #5144 2) Ensure that if big animal authentication is aborted, API calls should be stopped. Fixes #5275 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4

[Patch] - Bug #7472 - The message "EDB Big Animal authentication process is in progress" is displayed on the Big Animal credentials screen if the user closes the URL with the crossbar without authenti

2022-09-15 Thread Yogesh Mahajan
Hello Team, Please find the attached patch which fixes 2 issues below - 1.Bug #7472 - The message "EDB Big Animal authentication process is in progress" is displayed on the Big Animal credentials screen if the user closes the URL with the crossbar without authentication 2.Bug #7636 - Improve the e

Re: HEADS-UP: Redmine -> Github issue migration

2022-09-15 Thread Dave Page
All, The migration has now completed. Please log or update any tickets at https://github.com/postgres/pgadmin4/issues Any updates to tickets on Redmine from now on (until we can figure out how to make it read-only) may not be seen. On Tue, 13 Sept 2022 at 11:39, Dave Page wrote: > All, > > Ove

Re: [pgAdmin][RM-7637]: Wrong SQL displayed in difference if user create rls policy on the table without column

2022-09-15 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 15, 2022 at 1:48 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached the patch for RM-7637 > : Wrong SQL displayed in > difference if user creates rls policy on the tab

Re: [pgAdmin][RM7695] Server name not displayed correctly in process tab if server name has special characters.

2022-09-15 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 15, 2022 at 3:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the mentioned issue. > It also reverts a few code changes done for SonarQube security fixes. > Please review. > > -- > Thanks, > Aditya To

pgAdmin 4 commit: Fixed an issue where the wrong SQL displayed in diffe

2022-09-15 Thread Akshay Joshi
Fixed an issue where the wrong SQL displayed in difference if the user create an RLS policy on the table without a column. Fixes #7637 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=769f58970e0aafdebf0be703c787519cbfe34218 Author: Nikhil Mohit

pgAdmin 4 commit: Fixed an issue where server names with special charac

2022-09-15 Thread Akshay Joshi
Fixed an issue where server names with special characters are not displayed correctly in the process tab. Fixes #7695 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04b1e2604178616b2e4b4e884cd63fe379c9b8c2 Author: Aditya Toshniwal Modified

[pgAdmin][RM7695] Server name not displayed correctly in process tab if server name has special characters.

2022-09-15 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the mentioned issue. It also reverts a few code changes done for SonarQube security fixes. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM76

[pgAdmin][RM-7637]: Wrong SQL displayed in difference if user create rls policy on the table without column

2022-09-15 Thread Nikhil Mohite
Hi Hackers, Please find attached the patch for RM-7637 : Wrong SQL displayed in difference if user creates rls policy on the table without column -- *Thanks & Regards,* *Nikhil Mohite* *Senior Software Engineer.* *EDB Postgres*

Re: [pgAdmin][RM7557] pgAdmin failed to start due to bin path migration

2022-09-15 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 15, 2022 at 11:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes an issue where an exception occurs when migrating an > old bin path preference. > Please review. > > -- > Thanks, > Aditya Toshniwal > pg

Re: [pgAdmin][RM7709] ERD Throws error if variable added to column

2022-09-15 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Sep 15, 2022 at 12:24 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the issue. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Software Architect | *edbpostgres.com* >

pgAdmin 4 commit: Fixed an issue where pgAdmin failed to start due to b

2022-09-15 Thread Akshay Joshi
Fixed an issue where pgAdmin failed to start due to bin path migration. Fixes #7557 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=985546fff6110b099876ec5c012eaa2bf4f57ba7 Author: Aditya Toshniwal Modified Files -- docs/en_US/re

pgAdmin 4 commit: Fixed an issue where ERD throws an error if variable

2022-09-15 Thread Akshay Joshi
Fixed an issue where ERD throws an error if variable is added to the column. Fixes #7709 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ac233f2446260dfb5dfc06ce2fa0bfcafea0536 Author: Aditya Toshniwal Modified Files -- docs/en_

pgAdmin 4 commit: 1) Warn the user when connecting to a server that is

2022-09-15 Thread Akshay Joshi
1) Warn the user when connecting to a server that is older than pgAdmin supports. 2) Fixed Debugger API test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01a9a41bd98205dca409796fcc030fa3678d65f3 Modified Files -- .../ser