There is an error when checking the major version of servers in schema diff

Hi, The function get_round_val() outputs the wrong value when major version is before 10. For example, Source server version: 90500 Target server version: 90502 Or Source server version: 90502 Target server version: 90602 The attached patch shows the changes. -- Thanks && regards Hua

RE: Is there a mistake in line 22 of Make.bat?

Thanks for your answer. -- Thanks & Regards HuangJ From: Dave Page Sent: Thursday, January 14, 2021 5:15 PM To: Huang, Jun/黄 军 Cc: pgadmin-hack...@postgresql.org Subject: Re: Is there a mistake in line 22 of Make.bat? Hi On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun mailto:huan

Is there a mistake in line 22 of Make.bat?

Hi, The following code is line 22 of Make.bat: if "%Platform%" == "X86" ( I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the result is "x86"(not "X86"). If it's a mistake, the attached patch adds the changes. Regrads, Huang Fix-Platfrom.patch Description: Fix-

The target connection was wrong in function check_version_compatibility()

Hi, The target connection was made by source connection manager(it should be made by target connection manager) in function check_version_compatibility(web\pgadmin\tools\schema_diff\__init__.py). Attached patch adds the changes. Regrads, Huang 0001-Target-connection-was-wrong-in-function.pat