[patch][pgAdmin] RM7150 Error "Not allowed" when uploading a CSV while being in "Desktop mode"

2022-02-03 Thread Rahul Shirsat
Hi Hackers, Please find the patch which resolves the issue of csv not allowed in Desktop mode. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM7150.patch Description: Binary data

[patch][pgAdmin] RM7136 Query tool may display incorrect database label

2022-02-01 Thread Rahul Shirsat
Hi Hackers, Please find the patch which resolves the issue of incorrect database labels. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM7136.patch Description: Binary data

[patch][pgAdmin] RM7118 pgAdmin 4 v6.4 - Import/export server groups

2022-01-25 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the file download issue in the storage manager. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM7118.patch Description: Binary data

Re: [patch][pgAdmin] RM7018 [React] Port Restore dialog to React.

2022-01-06 Thread Rahul Shirsat
On Tue, Dec 28, 2021 at 1:50 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Sun, Dec 26, 2021 at 4:18 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Aditya/Akshay, >> >> Please find the comments below. >> >&g

[patch][pgAdmin] RM7029 The PGv14 SQL FUNCTION syntax of RETURN or BEGIN ATOMIC is not recognized nor displayed

2021-12-06 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of sql function with atomic definition in PGv14. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM7029.patch Description: Binary data

[patch][pgAdmin4] RM7006 With Python 3.10 eventlet==0.31.0 breaking the application

2021-11-17 Thread Rahul Shirsat
Hi Hackers, Ensure that with Python 3.10 and the latest eventlet dependency should not break the application. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM7006.patch Description: Binary data

[patch][pgAdmin4] RM6832 oauth2 + internal authentication failure when order is changed in config file

2021-11-10 Thread Rahul Shirsat
Hi Hackers, Ensure that internal authentication when combined with other authentication providers, the order of internal source should not matter while picking up the provider. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6832.patch Description: Binary data

[patch][pgAdmin] RM6859 Properties panel is not updated when any object is added from the browser tree

2021-10-26 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue properties panel updation. This patch will have unique behaviour throughout, i.e. new node will be selected on creation, instead of selecting the collection node. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB

[patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens

2021-10-22 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of not opening a reassign/drop owned dialog box. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6949.patch Description: Binary data

Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue

2021-10-19 Thread Rahul Shirsat
Hackers, Please ignore the above mail. Find the updated patch attached. On Tue, Oct 19, 2021 at 2:26 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which resolves the Type collection delete > issue. > > -- &g

[patch][pgAdmin] RM6858 Types collection properties tab delete issue

2021-10-19 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the Type collection delete issue. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6858.patch Description: Binary data

[pgaweb][patch] Update style guide WRT RM6754

2021-10-15 Thread Rahul Shirsat
Hi Hacker, Please find the attached patch which adds a new activeline-light color for standard themes, and minor updates regarding other themes. Also added babel dependency in requirement.txt which was missing. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation

[patch][pgAdmin] RM6802 Unable to edit trigger for advanced servers

2021-10-14 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of editing triggers for advanced servers. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6802.patch Description: Binary data

[patch][pgAdmin] RM6754 Color of query highlighting in query tool should be less intensive

2021-10-12 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of intensive query highlighting in the query tool. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6754.patch Description: Binary data

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-10-05 Thread Rahul Shirsat
rote: > Thanks, the patch applied. > > On Mon, Oct 4, 2021 at 6:34 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which resolves one more additional issue >> reported by Aditya. &

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-10-04 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves one more additional issue reported by Aditya. On Thu, Sep 30, 2021 at 3:32 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Sep 30, 2021 at 1:46 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrot

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-09-30 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch for fixing some additional issues. On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> H

[patch][pgAdmin] RM6822 User can not expand the server on Windows

2021-09-29 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the tree expanding issue on windows. Fix is tested on Windows 2016 & Mac. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6822.patch Description: Binary data

[patch][pgAdmin] RM6791 Index Node - [Create]> Controls for Sort & Nulls should be changed, [Edit]> Definition>Columns sections are editable

2021-09-27 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issues of sort & nulls in index. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6791.patch Description: Binary data

[patch][pgAdmin] RM6806 [Type Node] Schema icon is not visible in the drop-down of General tab

2021-09-27 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of schema icon not visible in drop down of Type Node in General Tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6806.patch Description: Binary data

Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-09-20 Thread Rahul Shirsat
Hi Akshay, Please find the updated patch. On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi wrote: > Hi Rahul > > Patch not applied, rebase and send the patch again. > > On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >&

[patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-09-16 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the below issue: 1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue. 2. Range Type - Loading icons are shown in different drop down tabs. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation

[patch][pgAdmin] RM6743 Security> Privileges is not displayed for catalog nodes

2021-09-16 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of Privileges not shown in catalog nodes for Properties tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6743.patch Description: Binary data

[patch][pgAdmin] RM6713 [Debugger] Messages tab hide last message

2021-09-15 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of the messages tab hiding the last message. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6713.patch Description: Binary data

[patch][pgAdmin] RM6712 Collapse & expand arrows are not populating correctly in case of nested if.

2021-09-08 Thread Rahul Shirsat
Hi Hackers, Please find below patch which resolves the issue of collapse & expand arrows mismatch in case of nested IF. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6712.patch Description: Binary data

[patch][pgAdmin] RM6625 Smarter closing of Tabs

2021-09-01 Thread Rahul Shirsat
Hi Hackers, Please find the patch for feature addition of smarter closing of tabs. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6625.patch Description: Binary data

Re: [pgAdmin][patch] RM6675 Port package and it’s child node to React

2021-08-19 Thread Rahul Shirsat
2021 at 7:55 PM Akshay Joshi wrote: > Hi Rahul > > On Wed, Aug 18, 2021 at 12:31 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which ports package and its child nodes to >> react

[pgAdmin][patch] RM6675 Port package and it’s child node to React

2021-08-18 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which ports package and its child nodes to react. A minor change of fullTab for sql type is added for the Properties tab. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6675.patch Description: Binary data

[pgAdmin][patch] RM6661 [React] Port Index node to react

2021-08-10 Thread Rahul Shirsat
Hi Hackers, Please find the below attached patch which migrates the Index node to react. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6661.patch Description: Binary data

[pgAdmin][patch] RM6655 [React] Port Schema & Catalog node to react

2021-08-04 Thread Rahul Shirsat
url is not provided. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6655.patch Description: Binary data

[pgAdmin] RM6602 [React] Port Types node to react

2021-08-02 Thread Rahul Shirsat
uded in it. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6602.patch Description: Binary data

[patch][pgAdmin] RM6643 When Data type 'Range' is selected while creating custom data type, required options are not loaded

2021-07-28 Thread Rahul Shirsat
Hi Hackers, Please find the patch which resolves the issue of fetching dependent properties in Range type. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6643.patch Description: Binary data

Re: [patch][pgAdmin] RM6369 CSRF errors for stale sessions

2021-07-13 Thread Rahul Shirsat
l or config_system file will > not be reflected. > > Thanks, > Khushboo > > On Tue, Jul 13, 2021 at 6:24 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which increases the session

[patch][pgAdmin] RM6369 CSRF errors for stale sessions

2021-07-13 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which increases the session expiration time for desktop mode to 1 week. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6369.patch Description: Binary data

[patch][pgAdmin] RM6580 5.4 throws exception: TypeError: 'NoneType' object is not subscriptable

2021-07-13 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of 'NoneType' object while logging out in Server Mode. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6580.patch Description: Binary data

[pgAdmin][RM6587] [React] Port FTS Template, FTS Parsers nodes to react

2021-07-09 Thread Rahul Shirsat
Hi Hackers, Please find the below patch which ports fts_template, fts_parsers nodes to react. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6587.patch Description: Binary data

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-07-02 Thread Rahul Shirsat
te: >> >>> Hi >>> >>> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >>> rahul.shir...@enterprisedb.com> wrote: >>> >>>> Hi All, >>>> >>>> Please find the attached patch for resolving this issue wrt ab

[patch][pgAdmin] RM6550 5.4 running on kubernetes fails to log in even with the right environment variables defined

2021-07-02 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the login issue for a user having a non-existing email id. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6550_RM6560.patch Description: Binary data

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Rahul Shirsat
Hi All, Please find the attached patch for resolving this issue wrt above suggestion. Let me know if anyone has any queries. On Tue, Jun 29, 2021 at 9:20 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Dave / Aditya, > > For a time being, Let's make a call to gett

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-29 Thread Rahul Shirsat
d, it'll be marked as fuzzy or untranslated - in other words, > gettext knows how to handle that). > > >> >>> >>>> >>>> On Tue, Jun 29, 2021 at 7:01 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>>

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Rahul Shirsat
I feel gettext sometimes won't escape the characters as it should be. I now tried to escape those using some utils. Please find the updated patch. On Mon, Jun 28, 2021 at 9:33 PM Dave Page wrote: > Hi > > On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat < > rahul.shir...@enterpri

[patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-28 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch for fixation of jenkins failure. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. jenkins_failure_fix.patch Description: Binary data

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

2021-06-07 Thread Rahul Shirsat
Done. >> >>> >>>- "Please note that the database you are working on has been moved >>> or renamed to ${data.actual_db_name}. Refresh databases in browser >>> panel or >>> click OK to continue.." should be changed to "

[patch][pgAdmin] RM1591 [Web Based] Grant Wizard should also add under package node

2021-06-02 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which adds the functionality of grant wizard to packages. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM1591.patch Description: Binary data

[Patch] RM6478 Duplicates on SQL tab for table with more than one partition

2021-05-31 Thread Rahul Shirsat
Hi Hackers, Please find the patch which resolves the mentioned issue of duplicate on sql tab for table. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6478.patch Description: Binary data

[Patch][pgAdmin] RM4203 Rename Database by another user

2021-05-26 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of renaming the database by another user. A minor issue of navigation button alignment is also fixed in this patch. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4203.patch Description: Binary

[pgAdmin][patch] RM4064 Window maximize/restore, standardize

2021-05-24 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch for your reference, which adds the functionality of window maximise/restore currently only for properties dialog. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4064.patch Description: Binary data

Re: [pgAdmin][patch] RM6329 [SQL] bad child table DDL

2021-04-26 Thread Rahul Shirsat
Hello Akshay, Please find the updated patch. On Mon, Apr 26, 2021 at 2:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Apr 23, 2021 at 2:08 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please fi

[pgAdmin][patch] RM6329 [SQL] bad child table DDL

2021-04-23 Thread Rahul Shirsat
Hi Hackers, Please find below patch which resolves the issue of inherited key constraint getting in partition SQL. Simultaneously, added the partition table's RLS policy, Triggers, Rules, Compound Triggers in the main SQL tab as previously it was not included. -- *Rahul Shirsat* Senior

[pgAdmin][patch] RM6107 Check constraint input size flickers when editing it

2021-04-12 Thread Rahul Shirsat
Hi Hackers, Please find the patch which resolves the flickering issue of the input box on check constraints. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6107.patch Description: Binary data

[pgAdmin][patch] [Macro support] RM5908 Shortcut keys should be working with Manage macro & RM6161 Macro SQL input box cursor issue.

2021-04-09 Thread Rahul Shirsat
acro support modal, but also for other models related to sqleditor (description in RM6161 <https://redmine.postgresql.org/issues/6161>) which is resolved in this fix. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5908_RM6161.patch Description: Binary data

[pgAdmin] [patch] RM6333 Help dialog issue if we set "Open in new browser tab" for Query tool & ERD.

2021-04-06 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of help dialogue for Query tool & ERD tool on nwjs app. Also in the flow, verified Schema diff & Debugger where no issues found as these can be opened in the new tab. -- *Rahul Shirsat* Senior Software Engineer | Ente

SonarQube Fixes #5 Roles & Functions

2021-03-17 Thread Rahul Shirsat
to reduce its Cognitive Complexity from 17 to the 15 allowed -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. sonar_roles_functions.patch Description: Binary data

[pgAdmin] [patch] RM5319 [Code Coverage] Improve API test cases for Server module

2021-03-16 Thread Rahul Shirsat
Hi Hackers, Please find the patch for code coverage to improve test cases for server modules. Also a minor issue of server creation when created along with Advanced Tab setting passfile keeping auto connect disable is fixed along with this patch. -- *Rahul Shirsat* Senior Software Engineer

[pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics

2021-03-11 Thread Rahul Shirsat
view should display for Explain Analyze -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM4849_RM4847.patch Description: Binary data

[pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language

2021-02-25 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of save button getting enabled for procedure, additionally for functions as well. There is no support for Estimated cost in Procedure for PG, which is also taken care of in this fix. -- *Rahul Shirsat* Senior Software Engineer

[pgAdmin] RM5871 Show username in 'Connect to Server' pop up when server is created using service & user.

2021-01-25 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch for this issue. diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/password.html b/web/pgadmin/browser/server_groups/servers/templates/servers/password.html index 35f4e2a16..5ed1fc4af 100644 ---

Re: SonarQube Fixes #4 Database & Foreign Tables

2021-01-21 Thread Rahul Shirsat
EPAS both. > > *Done!* > >- Add comments for all the new functions introduce in the patch. > > *Added!* > > On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the att

SonarQube Fixes #4 Database & Foreign Tables

2021-01-21 Thread Rahul Shirsat
to the 15 allowed.* -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. sonar_issues_database_foreign_tables.patch Description: Binary data

[pgAdmin] RM6098 Manually deleting from table view hangs

2021-01-18 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6098.patch Description: Binary data

Re: [pgAdmin] RM4892 pgAdmin "Inception"

2021-01-12 Thread Rahul Shirsat
Hi Hackers, Please find the patch which reverts the previous changes. Code changes do not solve the issue, so a workaround is mentioned in the RM to cater the issue. On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Dec 23, 2020 at 8:23 PM Rahu

[pgAdmin] RM6128 RM6084 datistemplate issue

2021-01-11 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch below which resolves the issue of datistemplate. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6128_RM6084.patch Description: Binary data

Re: [pgAdmin] RM4892 pgAdmin "Inception"

2020-12-23 Thread Rahul Shirsat
Just forgot to mention, patch consists of one more fix of a schema not loading on several refresh of browser or startup of application - *FIXED* [image: image.png] On Wed, Dec 23, 2020 at 8:16 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please fi

[pgAdmin] RM4892 pgAdmin "Inception"

2020-12-23 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of pgadmin Inception in Firefox browser. The fix is tested on: 1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit) 2. Windows 2016 Firefox Browser 84.0.1 (64-bit) -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB

[pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option

2020-12-17 Thread Rahul Shirsat
"Comparing objects..." shows up in Firefox. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6084.patch Description: Binary data

[pgAdmin] RM5973 Option to Never Expire a user account is unintuitive

2020-12-16 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which adds more information for letting users know about the account password expiry for Login/Group Role. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5973.patch Description: Binary data

[pgAdmin] RM5875 template1 is shown after you use pg_upgrade

2020-12-15 Thread Rahul Shirsat
1914, 64-bit) 2. MacOSX -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM5875.patch Description: Binary data

Add folder icon issue

2020-12-07 Thread Rahul Shirsat
Hi Hacker, Please find a minor fix for the add-folder icon issue on select / create file manager. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. add-folder-icon-issue.patch Description: Binary data

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-12-03 Thread Rahul Shirsat
Thanks Dave. I have closed the issue. On Thu, Dec 3, 2020 at 3:02 PM Dave Page wrote: > Hi > > Please check: https://www.pgadmin.org/faq/#13 > > On Thu, Dec 3, 2020 at 8:54 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Dave, >> >

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-12-03 Thread Rahul Shirsat
On Wed, Dec 2, 2020 at 4:33 PM Dave Page wrote: > Hi > > On Tue, Dec 1, 2020 at 5:51 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Could you please add below FAQ point for SameSite Safari issue: >> >> Question

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Rahul Shirsat
t; >>> Fixed an issue where the validation error message is shown twice. Fixes >>> #5736 >>> >>> Branch >>> -- >>> master >>> >>> Details >>> --- >>> >>> https://git.postgresql.org/gitweb?p

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-12-01 Thread Rahul Shirsat
OKIE_SAMESITE = None SESSION_COOKIE_SECURE = True Do suggest or add any points if I am missing them. Also, let me know once this is done, So that I will close the ticket. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. On Mon, Nov 30, 2020 at 7:30 PM Rahul S

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-11-30 Thread Rahul Shirsat
This was the part of our internal quality testing, where it got encountered. Currently, none of the users have complained about this on their specific browser versions. On Mon, Nov 30, 2020 at 5:12 PM Dave Page wrote: > Hi > > On Mon, Nov 30, 2020 at 7:12 AM Rahul Shirsat <

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-11-29 Thread Rahul Shirsat
Even webkit has confirmed about this issue : https://bugs.webkit.org/show_bug.cgi?id=198181 - Users facing this issue in v12.x On Thu, Nov 26, 2020 at 6:57 PM Dave Page wrote: > Hi > > On Wed, Nov 25, 2020 at 10:37 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> w

Unable to download macros query results (reference #RM5965)

2020-11-26 Thread Rahul Shirsat
to download the already ran macros or to download the query result present in the query tool. Please suggest. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation.

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-11-26 Thread Rahul Shirsat
Yes Akshay. I think we should go ahead adding this approach in the pgadmin faqs, we would not be fixing this in our code as we don't know when Apple would fix its issue. On Thu, Nov 26, 2020 at 11:27 AM Akshay Joshi wrote: > Hi Rahul > > On Wed, Nov 25, 2020 at 4:07 PM Rahu

SameSite issues in Safari Browser (reference #RM5975)

2020-11-25 Thread Rahul Shirsat
tion or combination of both, but with caution. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation.

[pgAdmin4] RM5943 Implement folder rename in Storage Manager

2020-11-13 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which implements renaming a folder in Storage Manager. *Also fixed a minor issue when:* User clicks the rename button (for file & folder both) and without renaming it, clicks anywhere, the file name becomes blank - *Resolved* -- *Rahul Shi

Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed

2020-11-11 Thread Rahul Shirsat
user_old specific issues while removing the orphan process, I think, programmatically, it is handled. Note: Previous sonarqube issue in this mail trace is also considered in this patch due to many similar file changes. On Tue, Nov 10, 2020 at 1:59 PM Rahul Shirsat < rahul.shir...@enterprisedb.

SonarQube Fixes #3

2020-11-09 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch to fix the SonarQube code smells having rules: - Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. Also, corrected one of the backup test cases which were failing in server mode. -- *Rahul Shirsat* Software

IPV6 setup #RM5582

2020-11-05 Thread Rahul Shirsat
either Windows nor Ubuntu even after setting up radvd). Even my internet service provider does not provide the global address (only link-local address). For now, I have suggested the author of the issue to test from his end. But to verify from our side, can you give some thought on this? -- *Rahul S

[pgAdmin][RM5736] Validation error msg showing twice on create table- add column.

2020-10-29 Thread Rahul Shirsat
the requirements. Row will not be highlighted when the column name and type is added/changed. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5736.patch Description: Binary data

Re: [pgAdmin][RM3318] Download Backup Files

2020-10-23 Thread Rahul Shirsat
ase fix and send the patch. > > On Tue, Oct 20, 2020 at 9:27 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the below patch which allows users to download the backup and >> export files generate

[pgAdmin][RM3318] Download Backup Files

2020-10-20 Thread Rahul Shirsat
Hi Hackers, Please find the below patch which allows users to download the backup and export files generated on shared drive. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3318.patch Description: Binary data

Re: [pgAdmin] Bug #5831 Internal server error displayed if user open query tool window inside view data

2020-09-14 Thread Rahul Shirsat
Hi Hackers, Please find below fixes : 1. Query editor via view/edit data - fixed panel title issue. 2. Fixed Schema diff panel title on new tab. On Mon, Sep 14, 2020 at 2:28 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attac

[pgAdmin] Bug #5831 Internal server error displayed if user open query tool window inside view data

2020-09-14 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which fixes the open query tool window inside view data. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5831.patch Description: Binary data

[pgAdmin][Patch] #5746 setup.py --load-server does not allow loading connections that use pg_services

2020-08-31 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch below which fixes the issue regarding --load-servers having service based server connection. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5746.patch Description: Binary data

Re: #4059 Query tool new tab recurrence

2020-08-27 Thread Rahul Shirsat
*Removing DL not related PG directly.* ++pgadmin-hackers. On Thu, Aug 27, 2020 at 1:48 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Dave, > > Working on one of the features #4059 > <https://redmine.postgresql.org/issues/4059>, assume that query too

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

2020-08-20 Thread Rahul Shirsat
ss’ > Done > > > Make the above changes and resend the patch. > > On Fri, Aug 14, 2020 at 8:34 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch to fix the SonarQube Code smells having >&g

[pgAdmin4][Patch] - SonarQube Fixes #2

2020-08-14 Thread Rahul Shirsat
t be found." 10 times. 3. Define a constant instead of duplicating this literal 'get_columns_for_table.sql' 3 times. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. sonar_qube_table_init.patch Description: Binary data

Bug #5664 SQL DDL output generator for view

2020-08-07 Thread Rahul Shirsat
could not be associated with its test cases, as the changes are related to VIEW's column, in which we cannot add columns to the VIEW and test it. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5664.patch Description: Binary data

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-31 Thread Rahul Shirsat
for this issue and rechecked with Yogesh, which seems to be fixed now. Could you please apply these relevant changes for this RM? On Wed, Jul 29, 2020 at 6:31 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Jul 29, 2020 at 3:52 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com&

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-29 Thread Rahul Shirsat
Hi Hackers, Ignore the previous patch. Find below the rebased patch. On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch below which fixes the issue of Start value while > updating the identity

[pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

2020-07-29 Thread Rahul Shirsat
, it only updates identity* - *Fixed* 2. *Cycled option issue - **Fixed* Steps to reproduce : - Update cycled to Yes, save it. - Now change it to No, trying saving, gives error. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM5632.patch Description: Binary data

Re: [pgAdmin][RM5646] User can not see RLS policies in the search object

2020-07-21 Thread Rahul Shirsat
Hi Hackers, Just for the information, the additional issue was the *incorrect node path set in RLS policy*, and not the search objects itself. On Tue, Jul 21, 2020 at 9:23 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch be

[pgAdmin][RM5646] User can not see RLS policies in the search object

2020-07-21 Thread Rahul Shirsat
Hi Hackers, Please find the patch below which fixes the issue of searching RLS policies in search objects. It also fixes the additional issue of search objects for RLS policies navigating to appropriate nodes by double clicking the found object. -- *Rahul Shirsat* Software Engineer

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

2020-07-10 Thread Rahul Shirsat
lying the patch, please rebase the patch and > send it again. > > Thanks, > Khushboo > > On Thu, Jul 9, 2020 at 1:25 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Wed, Jul 8, 2020 at 6:12 PM Rahul

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

2020-07-09 Thread Rahul Shirsat
Hi Hackers, Please find the updated patch below which fixes the issue in sslcompression changes. On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch which includes sonarqube fixes : > > 1. Refactor this function to reduc

[pgAdmin][SonarQube] Critical issue fixes - servers

2020-07-09 Thread Rahul Shirsat
allowed for *update *in servers/__init__.py *Note: Changes were tested in both Server mode & Desktop mode respectively.* -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. server-cognitive-comp-part-01.patch Description: Binary data

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

2020-07-08 Thread Rahul Shirsat
it can be continued with the latest code. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Rahul, > > - The storage parameters should be displayed in the parent table's SQL too

  1   2   >