Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

2018-05-31 Thread Dave Page
Thanks, patch pushed. On Wed, May 30, 2018 at 9:26 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue when you change any field in server > dialog 'tunnel_identity_file' model value get included unnecessarily in the > update request. > >

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

2018-05-31 Thread Victoria Henry
Hey Murtuza, Thanks for the explanation. That seems fine. This patch can be submitted. Sincerely, Victoria & Anthony On Thu, May 31, 2018 at 2:22 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello Victoria & Joao, > > > On Thu, May 31, 2018 at 2:17 AM, Joao De Almeida

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

2018-05-30 Thread Murtuza Zabuawala
Hello Victoria & Joao, On Thu, May 31, 2018 at 2:17 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > > We are having a hard time understanding the logic on the change. > > If tunnel_authentication is not on the model and the tunnel_identify_file > is present, we

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

2018-05-30 Thread Joao De Almeida Pereira
Hi Murtuza, We are having a hard time understanding the logic on the change. If tunnel_authentication is not on the model and the tunnel_identify_file is present, we change the tunnel_identify_file in the model to null? Is this what you mean? Thanks Victoria && Joao ​ On Wed, May 30, 2018 at 9:

[pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

2018-05-30 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue when you change any field in server dialog 'tunnel_identity_file' model value get included unnecessarily in the update request. eg: Change the server name and click on Save button, Check the request payload in network console. -- Regards, Murtuza Zabuawala En