Re: [pgAdmin4][Patch]: Code refactoring

2018-10-08 Thread Dave Page
Thanks, patch applied. On Fri, Oct 5, 2018 at 7:56 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > +++ > > Below are the changes, > - Move the duplicate code for closing the background process dialog into > 'test_gui_helper.py', > - Simplify the logic by removing the duplicate

Re: [pgAdmin4][Patch]: Code refactoring

2018-10-04 Thread Murtuza Zabuawala
+++ Below are the changes, - Move the duplicate code for closing the background process dialog into 'test_gui_helper.py', - Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'. On Thu, Oct 4, 2018 at 9:35 PM Murtuza Zabuawala

[pgAdmin4][Patch]: Code refactoring

2018-10-04 Thread Murtuza Zabuawala
Hi, PFA patch with some code refactoring. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company code_refactoring.diff Description: Binary data

Re: [pgAdmin4][Patch]: Code refactoring - Dashboard module

2017-10-09 Thread Dave Page
Thanks, applied. On Mon, Oct 2, 2017 at 2:21 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to refactor dashboard client side code for cancel & terminate > session button. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > T

[pgAdmin4][Patch]: Code refactoring - Dashboard module

2017-10-02 Thread Murtuza Zabuawala
Hi, PFA patch to refactor dashboard client side code for cancel & terminate session button. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/dashboard/static/js/dashboard.js b/web/pgadmin/dashboard/static/js/dashbo