Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Thanks, applied. On Wed, Apr 4, 2018 at 6:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 7:23 PM, Dave Page wrote: > >> Hi >> >> Thanks - I've committed this, however, could you send me an updated >> screenshot for the docs? The one you sent

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Thanks - I've committed this, however, could you send me an updated screenshot for the docs? The one you sent was a different size and colour depth from the others (and looked like a different scale). On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: >

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Joao, Thanks for the review. I have sent the patch. On Thu, Mar 29, 2018 at 8:46 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > > The patch looks like it is heading on the correct direction, we passed it > through our test pipeline and all tests passed. >

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Khushboo, The patch looks like it is heading on the correct direction, we passed it through our test pipeline and all tests passed. We found the same issues as Dave mentioned in his email, also after some code review we have the following questions/comments: . Why does modify_animation.js hav

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Mar 26, 2018 at 6:07 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attac

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Joao, On Tue, Mar 27, 2018 at 12:12 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > > Looks like you have a typo on your CSS where it reads 'zoomeIn' it should > be 'zoomIn'. > Thanks, I have sent the updated patch. > Also setting more parameters into the w

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Khushboo, Looks like you have a typo on your CSS where it reads 'zoomeIn' it should be 'zoomIn'. Also setting more parameters into the window, in our experience, is never good, so maybe it is time to create a real settings cache that can retrieve from the backend the settings, like this one. T

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #1978: Add an option to allow > user to disable alertifyjs and acitree animations. > I think these really need to be per-user settings, not per-installa

[pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi, Please find the attached patch to fix RM #1978: Add an option to allow user to disable alertifyjs and acitree animations. Thanks, Khushboo diff --git a/web/config.py b/web/config.py index 3d8f6f7..a91b2e2 100644 --- a/web/config.py +++ b/web/config.py @@ -364,6 +364,12 @@ COOKIE_DEFAULT_DOMAI