Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Murtuza Zabuawala
Hi Dave, I'm not able to re-produce the issue, I've updated the RM with my steps, please check and let me know If I missed anything. https://redmine.postgresql.org/issues/2937 -- Murtuza On Wed, Dec 6, 2017 at 10:17 AM, Dave Page wrote: > Hi > > Thanks, applied. I noticed whilst testing that t

Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Dave Page
Hi Thanks, applied. I noticed whilst testing that the Select button on the file dialogue can become enabled again following navigation to another directory. That then allows you to click it when no files are selected, which of course fails horribly. Can you take a look at that please? https://red

[pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Murtuza Zabuawala
Hi, PFA patch to fix referenced before assignment bug in file manager. RM#2934 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/__init__.py b/web/pgadmin/misc/file_manager/__init__.py index e51ac2

Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-04 Thread Dave Page
Thanks, patch applied. On Mon, Dec 4, 2017 at 11:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in file manager where user was able to click on > Select/Create button even if it's disabled. > RM#2923 > > -- > Regards, > Murtuza Zabuawala

[pgAdmin4][Patch]: To fix the issue in File manager

2017-12-04 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in file manager where user was able to click on Select/Create button even if it's disabled. RM#2923 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/static/js/file_ma