Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
Thanks, applied. On Thu, Jul 20, 2017 at 3:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > On Thu, Jul 20, 2017 at 6:17 PM, Dave Page wrote: > >> >> >> On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> It is base

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Murtuza Zabuawala
On Thu, Jul 20, 2017 at 6:17 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> It is based on Flask-Login module but >> 1) Flask-Login will mark a user as logged out when it detects that an >> existing session suddenly appears to come fro

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > It is based on Flask-Login module but > 1) Flask-Login will mark a user as logged out when it detects that an > existing session suddenly appears to come from a different originating IP > address or a

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Murtuza Zabuawala
It is based on Flask-Login module but 1) Flask-Login will mark a user as logged out when it detects that an existing session suddenly appears to come from a different originating IP address or a different browser. But it is unfortunate that Flask-Login does not enable this option by default. 2) It

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
Hi On Thu, Jul 20, 2017 at 12:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Tested it with PEM7 RestApi testsuite and it is working fine :) > The docs for this module say it's based on Flask-Login's session protect mechanism, and was intended to allow sessi

[pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Murtuza Zabuawala
Hi, PFA minor patch to make session more secure in web mode. RM#2584 Ref: https://flask-paranoid.readthedocs.io/en/latest/ Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/requirements.txt b/requirements.txt in