Re: [pgAdmin4][Patch] - PostgreSQL deployment on Amazon RDS

2022-02-14 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Feb 14, 2022 at 5:14 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Mon, Feb 14, 2022 at 2:17 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Jenkins is failing after committing the patch with error: >>

Re: [pgAdmin4][Patch] - PostgreSQL deployment on Amazon RDS

2022-02-14 Thread Khushboo Vashi
Hi, On Mon, Feb 14, 2022 at 2:17 PM Akshay Joshi wrote: > Hi Khushboo > > Jenkins is failing after committing the patch with error: > > *13:40:05* sed: couldn't edit venv/bin/__pycache__: not a regular > file*13:40:05* The command "sed -i > 's/#!.*\/python3/#\!\/usr\/pgadmin4\/venv\/bin\/pytho

Re: [pgAdmin4][Patch] - PostgreSQL deployment on Amazon RDS

2022-02-14 Thread Akshay Joshi
Hi Khushboo Jenkins is failing after committing the patch with error: *13:40:05* sed: couldn't edit venv/bin/__pycache__: not a regular file*13:40:05* The command "sed -i 's/#!.*\/python3/#\!\/usr\/pgadmin4\/venv\/bin\/python3/g' venv/bin/*" failed in "_create_python_virtualenv" with exit code 4.

Re: [pgAdmin4][Patch] - PostgreSQL deployment on Amazon RDS

2022-02-13 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Feb 14, 2022 at 11:02 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > On Fri, Feb 4, 2022 at 2:53 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Following are the review comments: >> >> *GUI:* >> >>- Can we rename the menu 'Dep

Re: [pgAdmin4][Patch] - PostgreSQL deployment on Amazon RDS

2022-02-04 Thread Akshay Joshi
Hi Khushboo Following are the review comments: *GUI:* - Can we rename the menu 'Deploy and Register a Cloud Instance...' to only 'Deploy Cloud Instance...' as we already have a Register menu? - Change the title of the server dialog from 'Create Server' to 'Register Server'. Change th