Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-13 Thread Dave Page
Thanks, patches applied! On Tue, Mar 13, 2018 at 9:53 AM, Victoria Henry wrote: > Hi Dave, > > We've made updated our previous patch to fix the error messages. Attached > are our updated patches. > > On Mon, Mar 12, 2018 at 8:48 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 12, 2018 at 5:18 P

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-13 Thread Victoria Henry
Hi Dave, We've made updated our previous patch to fix the error messages. Attached are our updated patches. On Mon, Mar 12, 2018 at 8:48 PM, Dave Page wrote: > Hi > > On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Dave and Murtuza, >>

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-13 Thread Dave Page
On Tue, Mar 13, 2018 at 12:12 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > I haven't implemented that intentionally because Khushboo is working on > the same for SSL and our code will conflict, So once Khushboo's patch gets > committed, I'll make changes for

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Murtuza Zabuawala
On Tue, Mar 13, 2018 at 9:45 AM, Ashesh Vashi wrote: > > On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Ashesh, >> >> I haven't implemented that intentionally because Khushboo is working on >> the same for SSL and our code will conflict, So once Khushboo's pa

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Ashesh Vashi
On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > I haven't implemented that intentionally because Khushboo is working on > the same for SSL and our code will conflict, So once Khushboo's patch gets > committed, I'll make changes for S

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Murtuza Zabuawala
Hi Ashesh, I haven't implemented that intentionally because Khushboo is working on the same for SSL and our code will conflict, So once Khushboo's patch gets committed, I'll make changes for Service file as well. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterpr

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Ashesh Vashi
Murtuza/Dave, I have to reviewed/seen the patch yet. But - I have a question. Have we used the service file in the external tools for backup, restore, and import/export functionalities? If not - we should fix that asap. We had missed that during SSL support, and now - we're fixing that. -- Than

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Dave Page
Hi On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave and Murtuza, > > Regarding this patch we refactored the Javascript code so that is lives in > a different file and added some tests. > > Also we found an issue with karma-jasmine that does

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Joao De Almeida Pereira
Hi Dave and Murtuza, Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests. Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit. Thanks Victoria

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Dave Page
Thanks, patch applied! On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri, Mar 9, 2018

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-09 Thread Murtuza Zabuawala
Hi Dave, I'll change the name and send you updated patch. On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: > HI > > On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add service parameter in server dialog. >> - Docs updated >> - Test case

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-09 Thread Dave Page
HI On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add service parameter in server dialog. > - Docs updated > - Test case added for Service ID parameter > > Please note, > I have extracted Connection class and Server manager c