Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-10-09 Thread Murtuza Zabuawala
Hi Harshal, Could you please look at the latest issue reported by user on https://redmine.postgresql.org/issues/2258#change-8312 It looks like regression of RM#2671 changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 18,

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-17 Thread Akshay Joshi
Thanks patch applied. On Fri, Sep 15, 2017 at 6:16 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > It's not issue; Try without quotes. As char data type stores only one > character so it's storing only leading quote (') and > truncating remaining characters (a'). > O

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-15 Thread Harshal Dhumal
Hi Akshay, It's not issue; Try without quotes. As char data type stores only one character so it's storing only leading quote (') and truncating remaining characters (a'). Only exception is when you want to store empty string (char) use two quotes (either single or double) they will translated bef

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Shirley Wang
Hi Harshal and Akshay, I'm noticing that the screenshots you attached have fonts that look different (ex. no font weights for table headers). Is that a result of the font bundling and needs to be updated? On Fri, Sep 15, 2017 at 12:18 AM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: >

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Harshal Dhumal
Thanks, I'll look into it. On Sep 14, 2017 5:31 PM, "Akshay Joshi" wrote: > Hi Harshal > > I have reviewed your patch it looks good to me. Only one issue I have > found with char[], when I store {'a','b','c'} it gets stored and when I > refreshed it shows {',','}. Please look into this issue. >

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Akshay Joshi
It works, sorry for the noise. On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi wrote: > Harshal, > > Can you please rebase the patch, it's not applied with the latest code. > > On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Tue, Sep 12, 2017 a

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Akshay Joshi
Harshal, Can you please rebase the patch, it's not applied with the latest code. On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi wrote: > > > On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: > >> Adding Akshay... >> > > Sure. > >> >> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: >> >>

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Akshay Joshi
On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: > Adding Akshay... > Sure. > > On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> >> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi,

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Dave Page
Adding Akshay... On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: > Akshay, can you review/commit this please? > > On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch to represent array data in datagrid with curl

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Dave Page
Akshay, can you review/commit this please? On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to represent array data in datagrid with curly > braces and > also allow user to save array with values like , , ' > *""*' and

Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-11 Thread Harshal Dhumal
Hi, Please find attached patch to represent array data in datagrid with curly braces and also allow user to save array with values like , , ' *""*' and "*''*" -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --gi