Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 9:20 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> As per my earlier comment, the dashboard.js fix is still failing. >> > But assigning the return value i

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > As per my earlier comment, the dashboard.js fix is still failing. > But assigning the return value is not a solution. Replace map with forEach so that it doesn't expect a return value at all (as there is non

Re: Patch for SonarQube UI fixes.

As per my earlier comment, the dashboard.js fix is still failing. On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Jun 15, 2020 at 4:45 PM Khushbo

Re: Patch for SonarQube UI fixes.

Thanks, patch applied. On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < >> aditya.toshni...@e

Re: Patch for SonarQube UI fixes.

Hi, On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> The patch looks good to me. >> > I think the dashboard.js fix is not accurate as when you

Re: Patch for SonarQube UI fixes.

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable. > > On Mon, Jun 15, 2020 at 4:22 PM Nikhil

Re: Patch for SonarQube UI fixes.

Hi, The patch looks good to me. On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some UI related issues of SonarQube scan. > Mainly fixes are related to removing duplicate properties in css class and > few js standard syntax fixe

Patch for SonarQube UI fixes.

Hi Team, I have fixed some UI related issues of SonarQube scan. Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes. PFA patch. sonarqube_ui_fix.patch Description: Binary data