Re: [pgAdmin]:Patch for SonarQube fixes.

2021-03-18 Thread Akshay Joshi
Thanks, patch applied. On Thu, Mar 18, 2021 at 2:51 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > I have fixed a few sonarQube issues.PFA patch. > >- Fts Configuration > > >1. Remove this commented-out code. > > >- Funtion > > >1. Update this functi

[pgAdmin]:Patch for SonarQube fixes.

2021-03-18 Thread Pradip Parkale
Hi Hackers, I have fixed a few sonarQube issues.PFA patch. - Fts Configuration 1. Remove this commented-out code. - Funtion 1. Update this function so that its implementation is not identical to the one on line 51. 2. Unexpected empty method 'validate'. - Trigger func

Re: [pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Mar 1, 2021 at 4:42 PM Nikhil Mohite wrote: > Hi Akshay, > > Sorry for the inconvenience, Please find the attached patch. > > Regards, > Nikhil Mohite. > > On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi > wrote: > >> Hi Nikhil >> >> You forgot to attach the patch :)

Re: [pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Nikhil Mohite
Hi Akshay, Sorry for the inconvenience, Please find the attached patch. Regards, Nikhil Mohite. On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi wrote: > Hi Nikhil > > You forgot to attach the patch :) > > On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >>

Re: [pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Akshay Joshi
Hi Nikhil You forgot to attach the patch :) On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Back-form (backform.pgadmin.js): > >- TypeError can be thrown as "$tabContent" might be null or undefin

[pgAdmin]: Patch for SonarQube fixes.

2021-03-01 Thread Nikhil Mohite
Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: 1. Back-form (backform.pgadmin.js): - TypeError can be thrown as "$tabContent" might be null or undefined here. 2. User Management (user_management.js): - 'self' is already declared in the upper scope. - '

Re: [pgAdmin]: Patch for SonarQube fixes

2021-01-19 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jan 19, 2021 at 12:58 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > Schema diff: > >- Refactor this function to reduce its Cognitive Complexity from 17 to >th

[pgAdmin]: Patch for SonarQube fixes

2021-01-18 Thread Nikhil Mohite
Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: Schema diff: - Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 44 to the 15 allowed. - Refactor this fu

Re: Patch for SonarQube fixes.

2021-01-17 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 18, 2021 at 11:15 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Preferences: > >- Refactor this function to reduce its Cognitive Complexity from 18 to >

Patch for SonarQube fixes.

2021-01-17 Thread Nikhil Mohite
Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: 1. Preferences: - Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. - Merge this if statement with the enclosing one. - Define a constant instead of duplicating this literal