Re: Query Tool JS Minimal Refactoring

Thanks, committed. On Fri, Aug 23, 2019 at 3:42 PM Yosry Muhammad wrote: > No it isn't. I just needed to update JS tests after the latest > modification and merging with master. Please find an updated patch > attached, sorry for the inconvenience. > > On Fri, Aug 23, 2019 at 3:47 PM Dave Page w

Re: Query Tool JS Minimal Refactoring

No it isn't. I just needed to update JS tests after the latest modification and merging with master. Please find an updated patch attached, sorry for the inconvenience. On Fri, Aug 23, 2019 at 3:47 PM Dave Page wrote: > Thanks - I assume this is dependent on the updatable columns patch, as the >

Re: Query Tool JS Minimal Refactoring

Thanks - I assume this is dependent on the updatable columns patch, as the JS tests fail if I apply it to the current GIT head? On Fri, Aug 23, 2019 at 1:07 PM Yosry Muhammad wrote: > Please find an updated patch attached. > > On Fri, Aug 23, 2019 at 1:23 PM Dave Page wrote: > >> Hi >> >> On Fr

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Fri, Aug 23, 2019 at 1:23 PM Dave Page wrote: > Hi > > On Fri, Aug 23, 2019 at 11:28 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> The v3 patch has changes like: >> diff --git a/docs/en_US/release_notes_4_13.rst >

Re: Query Tool JS Minimal Refactoring

Hi On Fri, Aug 23, 2019 at 11:28 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > The v3 patch has changes like: > diff --git a/docs/en_US/release_notes_4_13.rst > b/docs/en_US/release_notes_4_13.rst > index bc21dfeca..a0a3a38ef 100644 > --- a/docs/en_US/release_not

Re: Query Tool JS Minimal Refactoring

Hi Yosry, The v3 patch has changes like: diff --git a/docs/en_US/release_notes_4_13.rst b/docs/en_US/release_notes_4_13.rst index bc21dfeca..a0a3a38ef 100644 --- a/docs/en_US/release_notes_4_13.rst +++ b/docs/en_US/release_notes_4_13.rst @@ -22,5 +22,4 @@ Bug fixes | `Issue #2706

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Fri, Aug 23, 2019 at 7:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > This breaks the reconnect for query tool. Open a query tool, execute some > query and then restart the python server. Go to the query tool and click

Re: Query Tool JS Minimal Refactoring

Hi Yosry, This breaks the reconnect for query tool. Open a query tool, execute some query and then restart the python server. Go to the query tool and click execute. It will show a warning, on continuing it should connect again. It throws exception in browser console: Uncaught TypeError: Cannot re

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Mon, Aug 19, 2019 at 9:54 AM Yosry Muhammad wrote: > Jasmine tests passed on my machine, I will take another look once I have > access to my machine. > > On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi > wrote: > >> Hi Yosry >> >> Jasmine tests are failing,

Re: Query Tool JS Minimal Refactoring

Jasmine tests passed on my machine, I will take another look once I have access to my machine. On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi wrote: > Hi Yosry > > Jasmine tests are failing, can you please fix those and resend the patch. > > On Fri, Aug 16, 2019 at 11:23 PM Yosry Muhammad > wrote:

Re: Query Tool JS Minimal Refactoring

Hi Yosry Jasmine tests are failing, can you please fix those and resend the patch. On Fri, Aug 16, 2019 at 11:23 PM Yosry Muhammad wrote: > Hi hackers, > > Please find attached a patch with minimal refactoring of: > web/pgadmin/tools/sqleditor/static/js/sqleditor.js > > This includes merging 2

Query Tool JS Minimal Refactoring

Hi hackers, Please find attached a patch with minimal refactoring of: web/pgadmin/tools/sqleditor/static/js/sqleditor.js This includes merging 2 redundant functions into one and renaming some functions to have more expressive and consistent names. Please review ! Thanks. -- *Yosry Muhammad Yosr