Re: RE-SQL tests patch for packages node

2019-09-03 Thread Akshay Joshi
Thanks patch applied. On Tue, Sep 3, 2019 at 5:17 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Please check now. > > On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi > wrote: > >> Hi Navnath >> >> You forgot to add "create_package_with_all_options_msql.sql" and >> "alter_package_head

Re: RE-SQL tests patch for packages node

2019-09-03 Thread Akshay Joshi
Hi Navnath You forgot to add "create_package_with_all_options_msql.sql" and "alter_package_headers_and_comment_msql.sql" file in your patch. Please send the updated patch. On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi, > > Please find the modified p

Re: RE-SQL tests patch for packages node

2019-09-03 Thread navnath gadakh
Please check now. On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi wrote: > Hi Navnath > > You forgot to add "create_package_with_all_options_msql.sql" and > "alter_package_headers_and_comment_msql.sql" file in your patch. Please > send the updated patch. > > On Tue, Sep 3, 2019 at 1:36 PM navnath ga

Re: RE-SQL tests patch for packages node

2019-09-03 Thread navnath gadakh
Hi, Please find the modified patch. On Mon, Sep 2, 2019 at 5:43 PM Akshay Joshi wrote: > Hi Navnath > > Following are the review comments: > >- GRANT statement is not visible in RE-SQL for create and alter both. >(May be bug in Packages please fix that too) > > Done. > >- Delete pa

Re: RE-SQL tests patch for packages node

2019-09-02 Thread Akshay Joshi
Hi Navnath Following are the review comments: - GRANT statement is not visible in RE-SQL for create and alter both. (May be bug in Packages please fix that too) - Delete packages is missing in json file. - Add test cases to revoke privileges(delete all the privileges). Check Langua

Re: RE-SQL tests patch for packages node

2019-09-02 Thread navnath gadakh
Hi Dave, Please find the patch for M-SQL test cases for *Packages* module. Thanks! On Fri, Jul 12, 2019 at 4:02 PM Dave Page wrote: > Thanks, applied. > > On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find th

Re: RE-SQL tests patch for packages node

2019-07-12 Thread Dave Page
Thanks, applied. On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the modified patch for packages as test cases were > failing on some servers. > Thanks! > > > On Thu, Jul 11, 2019 at 1:53 PM Dave Page > wrote: > >> Thanks,

Re: RE-SQL tests patch for packages node

2019-07-12 Thread navnath gadakh
Hi Dave, Please find the modified patch for packages as test cases were failing on some servers. Thanks! On Thu, Jul 11, 2019 at 1:53 PM Dave Page wrote: > Thanks, applied. > > On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Navnath >> >> I h

Re: RE-SQL tests patch for packages node

2019-07-11 Thread Dave Page
Thanks, applied. On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi wrote: > Hi Navnath > > I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. > Attached is the modified patch which fix the issue. > Please work on child node (functions, procedure and variables) of Packages > on t

Re: RE-SQL tests patch for packages node

2019-07-11 Thread Akshay Joshi
Hi Navnath I have tested the patch and it is not working for EPAS 9.4, 9.5 and 9.6. Attached is the modified patch which fix the issue. Please work on child node (functions, procedure and variables) of Packages on top of modified patch. On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < navnath.gad

RE-SQL tests patch for packages node

2019-07-10 Thread navnath gadakh
Hi Dave, I have attached the patch for RE-SQL test cases for *Packages* node. Thanks! -- *Regards,* *Navnath Gadakh* re_sql_packages_tests_v1.patch Description: Binary data