Re: RM2233 - Scratch pad

2019-02-15 Thread Dave Page
Hi On Fri, Feb 15, 2019 at 1:53 PM Akshay Joshi wrote: > Hi Dave > > Following are my review comments: > >- When query is running then user should be able to work on Scratch >pad. > > That's a whole other issue - 3920 to be precise. > >- Try to resize the Data Output panel or just c

Re: RM2233 - Scratch pad

2019-02-15 Thread Dave Page
On Fri, Feb 15, 2019 at 1:29 PM Khushboo Vashi wrote: > > > > On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: >> >> Hi >> >> On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi >> wrote: >> > >> > Hi Dave, >> > >> > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >> >> >> >> Here's a draft patch

Re: RM2233 - Scratch pad

2019-02-15 Thread Khushboo Vashi
On Fri, Feb 15, 2019 at 6:35 PM Dave Page wrote: > Hi > > On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi > wrote: > > > > Hi Dave, > > > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > >> > >> Here's a draft patch for adding a scratch pad to the Query Tool, > >> similar to what we had in

Re: RM2233 - Scratch pad

2019-02-15 Thread Dave Page
Hi On Fri, Feb 15, 2019 at 11:53 AM Khushboo Vashi wrote: > > Hi Dave, > > On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: >> >> Here's a draft patch for adding a scratch pad to the Query Tool, >> similar to what we had in pgAdmin 3. >> >> Aside from regular review, can one of our CSS gurus (I'

Re: RM2233 - Scratch pad

2019-02-15 Thread Khushboo Vashi
Hi Dave, On Thu, Feb 14, 2019 at 8:14 PM Dave Page wrote: > Here's a draft patch for adding a scratch pad to the Query Tool, > similar to what we had in pgAdmin 3. > > Aside from regular review, can one of our CSS gurus (I'm looking at > you Aditya and Khushboo :-) ) help with the following ques

RM2233 - Scratch pad

2019-02-14 Thread Dave Page
Here's a draft patch for adding a scratch pad to the Query Tool, similar to what we had in pgAdmin 3. Aside from regular review, can one of our CSS gurus (I'm looking at you Aditya and Khushboo :-) ) help with the following questions: 1) I'm currently sizing the text area height using "height: ca