Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-21 Thread Akshay Joshi
Hi Navnath On Tue, Apr 21, 2020 at 12:21 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Hackers, > It's related to applying data sorting on table data by primary > key. > With the existing implementation, we can view the table's data using 4 > options with the

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-21 Thread navnath gadakh
Hello Hackers, It's related to applying data sorting on table data by primary key. With the existing implementation, we can view the table's data using 4 options with the different orders by default 1 - All Rows (No order) 2 - First 100 rows (ASC order) 3 - Last 100 rows (DESC order) 4 -

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-20 Thread navnath gadakh
Hi Khushboo, Please hold this patch for review I'm still optimizing the code in the patch. On Mon, Apr 20, 2020 at 9:16 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, >I have modified the code as per review comments. Please review the > attached patch file. >

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-20 Thread navnath gadakh
Hi Khushboo, I have modified the code as per review comments. Please review the attached patch file. Thanks! On Mon, Apr 20, 2020 at 10:56 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Navnath, > > Review comments: > > 1. If we have multiple Primary keys, then we should

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-19 Thread Khushboo Vashi
Hi Navnath, Review comments: 1. If we have multiple Primary keys, then we should include all the keys into the Order by clause. 2. In the Preferences dialog, please put this option in the Query Tool > Options instead of Result Grid and also change the Label. 3. Please optimize the code, as I

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-17 Thread navnath gadakh
Hello Hackers, Please find the modified patch with an option in Preferences for data sorting by the primary key. Also, the previous patch was not working with table has no primary key. Thanks! On Thu, Apr 16, 2020 at 5:01 PM Dave Page wrote: > > > On Thu, Apr 16, 2020 at 12:08 PM navnath

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-16 Thread Dave Page
On Thu, Apr 16, 2020 at 12:08 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave/Team, > This patch is related to the default sort order for the view > table data. In pgAdminIII default ordering is by primary key and this is > not working in pgAdminIV. > I have

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-16 Thread Khushboo Vashi
Hi Navnath, On Thu, Apr 16, 2020 at 4:38 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave/Team, > This patch is related to the default sort order for the view > table data. In pgAdminIII default ordering is by primary key and this is > not working in pgAdminIV. > I