Re: [pgAdmin][patch] Theme component usage fix

2022-07-04 Thread Akshay Joshi
Thanks, the patch applied On Mon, Jul 4, 2022 at 2:12 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please ignore the previous patch. Please review the attached patch. > > > On Mon, Jul 4, 2022 at 1:56 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: >

Re: [pgAdmin][patch] Theme component usage fix

2022-07-04 Thread Aditya Toshniwal
Hi, Please ignore the previous patch. Please review the attached patch. On Mon, Jul 4, 2022 at 1:56 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached a few more fixes related to theme usage. > > On Fri, Jul 1, 2022 at 3:06 PM Akshay Joshi > wrote: > >> Thanks,

Re: [pgAdmin][patch] Theme component usage fix

2022-07-04 Thread Aditya Toshniwal
Hi, Attached a few more fixes related to theme usage. On Fri, Jul 1, 2022 at 3:06 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Fri, Jul 1, 2022 at 2:08 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Attached patch fixes the failing JS test cases.

Re: [pgAdmin][patch] Theme component usage fix

2022-07-01 Thread Akshay Joshi
Thanks, the patch applied. On Fri, Jul 1, 2022 at 2:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached patch fixes the failing JS test cases. > > On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the patch applie

Re: [pgAdmin][patch] Theme component usage fix

2022-07-01 Thread Aditya Toshniwal
Hi, Attached patch fixes the failing JS test cases. On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Attached is the updated patch. >> >> On Thu, Jun

Re: [pgAdmin][patch] Theme component usage fix

2022-06-30 Thread Akshay Joshi
Thanks, the patch applied. On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch. > > On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Please fix the linter er

Re: [pgAdmin][patch] Theme component usage fix

2022-06-30 Thread Aditya Toshniwal
Hi, Attached is the updated patch. On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi wrote: > Hi Aditya > > Please fix the linter error and send the patch again. > > On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Attached is the rebased

Re: [pgAdmin][patch] Theme component usage fix

2022-06-30 Thread Akshay Joshi
Hi Aditya Please fix the linter error and send the patch again. On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the rebased patch. > > On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi

Re: [pgAdmin][patch] Theme component usage fix

2022-06-30 Thread Aditya Toshniwal
Hi, Attached is the rebased patch. On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi wrote: > Hi Aditya > > Can you please rebase and send the patch again. > > On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch fixes t

Re: [pgAdmin][patch] Theme component usage fix

2022-06-30 Thread Akshay Joshi
Hi Aditya Can you please rebase and send the patch again. On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the usage of the Theme component. > Please note, a component should not be wrapped in multiple Theme > com