Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Thanks, applied. On Wed, Feb 28, 2018 at 10:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > I have found the issue, it was in Backform control itself :) > Issue: We were passing today's date value as minDate option in pgAgent > schedule schema while rendering

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

On Wed, Feb 28, 2018 at 3:10 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > I do not have the pgAgent installed so it was a little it hard to test > this. > FWIW, you don't need to install pgAgent to test this - you can just load the SQL file I sent into

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hello Murtuza, I do not have the pgAgent installed so it was a little it hard to test this. After looking into the code I think we are missing some testing coverage around the pga_job Javascript part so that we can catch these problems. Even some code extraction can be done around the pg_jobset

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Dave, I have found the issue, it was in Backform control itself :) Issue: We were passing today's date value as minDate option in pgAgent schedule schema while rendering the control, So when server was sending previous datetime value it was not displaying it causing sync problem. -- Regards,

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

​Thanks Dave, I'll look into it. ​ On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote: > Hi > > On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> I'm not able to re-produce the issue, Could you hard refresh and try >>

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I'm not able to re-produce the issue, Could you hard refresh and try again? > I still see it. > > If possible could you please provide exact steps? > Attached is a dump of my test pgagent

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

I'm not able to re-produce the issue, Could you hard refresh and try again? If possible could you please provide exact steps? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 27, 2018 at 5:30 PM, Dave Page

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Dave, Could you please send screenshot? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote: > Hi > > Still not quite right - see the attached screenshot which is the

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Still not quite right - see the attached screenshot which is the result of simply viewing the properties of an existing job. Note that the start time is shown in the grid but not the subnode control. Thanks. On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hi Dave, As validation related patch was committed with RM#3148 [ Sorry about that I forgot to checkout :) ] PFA patch to fix the issues you mentioned, I have also removed extra error message from sub node collection control and made it optional via flag. -- Regards, Murtuza Zabuawala