Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Robert Eckhardt
On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > When we started the app we noticed some change in the front end. > > The line numbers in the Editor: > - We noticed a bug with the numbers where at 1 rows, the numbers

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Khushboo Vashi
On 27 Jun 2017 18:33, "Dave Page" wrote: Thanks - patch committed! Awsome job :-) Gr8. Finally no more rebase request for Harshal. :) On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- >

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Ashesh Vashi
On Tue, Jun 27, 2017 at 6:33 PM, Dave Page wrote: > Thanks - patch committed! > > Awsome job :-) > Woohoo! -- Thanks & Regards, Ashesh Vashi > > On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find rebased

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Dave Page
Thanks - patch committed! Awsome job :-) On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-26 Thread Dave Page
I'm sorry, it needs rebasing again. If you can do it quickly, I'll make sure it's the next patch I work on in that area. Thanks. On Mon, Jun 26, 2017 at 5:16 AM, Harshal Dhumal wrote: > Hi Dave, > > Please find updated rebased patch for RM2137 > > On Fri, Jun

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-23 Thread Dave Page
Hi Harshal, When can we expect an updated version of this patch? I think it's important to get this into the next release. Thanks! On Fri, Jun 16, 2017 at 10:55 AM, Dave Page wrote: > Hi, > > That's better - the failures are far less random now :-). I got the > following two