Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
On Mon, Jan 22, 2018 at 4:32 PM, Dave Page wrote: > On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi > wrote: > > Dave, > > > > We need to make habit of running the following command before committing > any > > javascript files. > >> > >> yarn run linter > > We do - it's called when creating the b

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
On Mon, Jan 22, 2018 at 4:29 PM, Ashesh Vashi wrote: > Dave, > > We need to make habit of running the following command before committing > any javascript files. > >> *yarn run linter* > > Surinder, Please run the following command to fix most of the indentation issues, but - you'll need to fix

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Dave Page
On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi wrote: > Dave, > > We need to make habit of running the following command before committing any > javascript files. >> >> yarn run linter We do - it's called when creating the bundle, which I always do when testing. This newer version of ESLint seem

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
Dave, We need to make habit of running the following command before committing any javascript files. > *yarn run linter* -- Thanks, Ashesh On Mon, Jan 22, 2018 at 4:25 PM, Dave Page wrote: > Hi Surinder, > > It seems that updating ESLint exposed various issues. Can you take a > look ASAP ple

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Surinder Kumar
Yes, I will look. Thanks, Surinder On Mon, Jan 22, 2018 at 4:25 PM, Dave Page wrote: > Hi Surinder, > > It seems that updating ESLint exposed various issues. Can you take a > look ASAP please? > > Thanks. > > > -- Forwarded message -- > From: pgAdmin 4 Jenkins > Date: Mon, Jan