Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Tue, Nov 10, 2020 at 3:44 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Schema dif dependency: > >- 'isChecked' is already declared in the up

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. I haven't committed changes for "sqlautocomplete/parseutils", as Dave suggested send the patch to pgcli. On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. ps

Re: Patch for SonarQube code scan fixes.

On Tue, Sep 8, 2020 at 11:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Sep 8, 2020 at 3:53 PM Dave Page wrote: > >> >> On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> sqlautocomplete co

Re: Patch for SonarQube code scan fixes.

Hi Dave, On Tue, Sep 8, 2020 at 3:53 PM Dave Page wrote: > > On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> sqlautocomplete code is mostly inherited from the pgcli project. Changing >> it might create trouble in updating the code wit

Re: Patch for SonarQube code scan fixes.

On Tue, Sep 8, 2020 at 11:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > sqlautocomplete code is mostly inherited from the pgcli project. Changing > it might create trouble in updating the code with new versions. > Send a patch upstream :-) > > On Tue, Sep 8, 2020

Re: Patch for SonarQube code scan fixes.

Hi, sqlautocomplete code is mostly inherited from the pgcli project. Changing it might create trouble in updating the code with new versions. On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as fol

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Tue, Aug 25, 2020 at 6:04 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Database: > >- Refactor this function to reduce its Cognitive Complex

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Fri, Aug 21, 2020 at 12:23 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Foreign servers: > >- Refactor this function to reduce its Cognitive C

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Mon, Aug 17, 2020 at 11:17 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. languages: > >- Refactor this function to reduce its Cognitive Compl

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Mon, Aug 10, 2020 at 3:39 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Schema dif directory compare: > >- Refactor this function to reduce i

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Wed, Aug 5, 2020 at 6:03 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Index Constraint: > >- Refactor this function to reduce its Cognitive Complexity from 31 to >the 15 a

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Wed, Aug 5, 2020 at 12:41 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Schema Domains and Domain Constraints: > >- Refactor this function to r

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Fri, Jul 31, 2020 at 6:35 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Utils Route: > >- Refactor this function to reduce its Cognitive Comp

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Wed, Jul 29, 2020 at 4:24 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > Foreign key init: > >- Refactor this function to reduce its Cognitive Co

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Tue, Jul 21, 2020 at 10:45 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Database utils: > >- Refactor this function to reduce its Cognitive Co

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Thu, Jul 16, 2020 at 9:29 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Servers file(utils): > >- Refactor this function to reduce its Cognitiv

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. I have changed the function name from "def _get_reverse_engineered_sql_for_" to "def _get_resql_for_", because function name is too long. On Mon, Jul 13, 2020 at 9:40 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issue

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Thu, Jul 9, 2020 at 4:11 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Table files(utils): > >- Refactor this function to reduce its Cognitive Complexity from 34 to >the 15

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Tue, Jul 7, 2020 at 10:27 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved the PEP8 issues, PFA updated patch. > > > Regards, > Nikhil Mohite. > > On Tue, Jul 7, 2020 at 10:19 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wr

Re: Patch for SonarQube code scan fixes

Hi Akshay, I have resolved the PEP8 issues, PFA updated patch. Regards, Nikhil Mohite. On Tue, Jul 7, 2020 at 10:19 AM Akshay Joshi wrote: > Hi Nikhil > > Fix the PEP8 issues. > > On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> I hav

Re: Patch for SonarQube code scan fixes

Hi Nikhil Fix the PEP8 issues. On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Table Index files(utils and init): > >- Refactor this function to reduce its Cognitive Complexit

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Wed, Jul 1, 2020 at 5:30 PM Ashesh Vashi wrote: > > > On Wed, Jul 1, 2020 at 5:28 PM Dave Page wrote: > >> >> >> On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> >>> On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < >>> nikhil

Re: Patch for SonarQube code scan fixes

On Wed, Jul 1, 2020 at 5:28 PM Dave Page wrote: > > > On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> I have fixed some code smell issues

Re: Patch for SonarQube code scan fixes

On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi wrote: > > On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> I have fixed some code smell issues in the SonarQube scan, PFA patch. >> Details as follows: >> 1. Functions files: >> >>- Remove

Re: Patch for SonarQube code scan fixes

On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Functions files: > >- Remove the unused local variable "args" > > 2. node.js file in browser/static: > >- "j" hides or potent

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Mon, Jun 29, 2020 at 7:48 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Sequences files: > >- Refactor this function to reduce its Cognitive Co

Re: Patch for SonarQube code scan.

Thanks, patch applied. On Fri, Jun 26, 2020 at 2:35 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > resolved PEP8 warnings PFA latest patch. > > On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please fix PEP8 issue

Re: Patch for SonarQube code scan.

Hi Team, resolved PEP8 warnings PFA latest patch. On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please fix PEP8 issues. Other than PEP8, everything looks good to me. > > Thanks, > Khushboo > > On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <

Re: Patch for SonarQube code scan.

Hi, Please fix PEP8 issues. Other than PEP8, everything looks good to me. Thanks, Khushboo On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Khushboo,

Re: Patch for SonarQube code scan.

On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Khushboo, > > Details as follows: > 1. Package files: > > 1. Refactor this function to reduce its Cognitive Complexity from 40 to > the 15 allowed. > 2. Refactor this function to reduce its Cognitive Compl

Re: Patch for SonarQube code scan.

Hi Khushboo, Details as follows: 1. Package files: 1. Refactor this function to reduce its Cognitive Complexity from 40 to the 15 allowed. 2. Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 2. Functions files: 1. Rename this local variable "argString" to mat

Re: Patch for SonarQube code scan.

Hi Nikhil, Can you please provide the details of the issue provided by SonarQube (so review would be easy) ? Thanks, Khushboo On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in SonarQube scan. > 1. Code sm

Re: Patch for SonarQube code scan.

Thanks, patch applied. On Wed, Jun 24, 2020 at 2:27 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > fixed some code smell in the database init file from the SonarQube scan. > > PFA patch. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB So