Re: Quick search for menu items & help articles

2021-01-15 Thread Akshay Joshi
>> know if anything missing. >>>> >>>> >>>> >>>> *From: *Dave Page >>>> *Date: *Thursday, 14 January 2021 at 10:26 PM >>>> *To: *Pramod Ahire >>>> *Cc: *pgadmin-hackers >>>> *Subject: *Re: Quick

Re: Quick search for menu items & help articles

2021-01-15 Thread Dave Page
>>> >>> >>> >>> Thank you for comments ! I had described points below. Please do let me >>> know if anything missing. >>> >>> >>> >>> *From: *Dave Page >>> *Date: *Thursday, 14 January 2021 at 10:26 PM >>

Re: Quick search for menu items & help articles

2021-01-15 Thread Akshay Joshi
below. Please do let me >> know if anything missing. >> >> >> >> *From: *Dave Page >> *Date: *Thursday, 14 January 2021 at 10:26 PM >> *To: *Pramod Ahire >> *Cc: *pgadmin-hackers >> *Subject: *Re: Quick search for menu items & help articles >> >&

Re: Quick search for menu items & help articles

2021-01-15 Thread Dave Page
ramod Ahire > *Cc: *pgadmin-hackers > *Subject: *Re: Quick search for menu items & help articles > > > > Hi > > > > On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire < > pramod.ah...@enterprisedb.com> wrote: > > Hi Team, > > > > Please find

Re: Quick search for menu items & help articles

2021-01-14 Thread Pramod Ahire
Hi Dave, Thank you for comments ! I had described points below. Please do let me know if anything missing. From: Dave Page Date: Thursday, 14 January 2021 at 10:26 PM To: Pramod Ahire Cc: pgadmin-hackers Subject: Re: Quick search for menu items & help articles Hi On Thu, Ja

Re: Quick search for menu items & help articles

2021-01-14 Thread Akshay Joshi
Hi Pramod Following are the review comments: - linter issue "Undefined variable $black" - In Desktop mode remove the separator beside the search icon. On Thu, Jan 14, 2021 at 10:18 PM Pramod Ahire wrote: > Hi Team, > > > > Please find the attached designs & patch that contains complete

Re: Quick search for menu items & help articles

2021-01-14 Thread Dave Page
Hi On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire wrote: > Hi Team, > > > > Please find the attached designs & patch that contains complete > functionality except below to do for quick search. > > > > To Do: > > > >- Unit test cases are not that sufficient to cover complete code, but >will