Re: Re-[Sonarqube]- Clumsy code

Thanks, patch applied. On Thu, Jun 18, 2020 at 3:21 PM Satish V wrote: > Hi Akshay, > > Please find the updated Patch in the attachment which does not introduce > more code smell. > > Thanks > Sathish V > > On Thu, Jun 18, 2020 at 12:48 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

Re: Re-[Sonarqube]- Clumsy code

Hi Akshay, Please find the updated Patch in the attachment which does not introduce more code smell. Thanks Sathish V On Thu, Jun 18, 2020 at 12:48 PM Akshay Joshi wrote: > Hi Satish > > Fixes like below will create another code smell in SonarQube: > >- !(m.label == 'pg_global') should be

Re: Re-[Sonarqube]- Clumsy code

Hi Satish Fixes like below will create another code smell in SonarQube: - !(m.label == 'pg_global') should be *(m.label != 'pg_global')* - !(_.isUndefined(index) || index == ''); - !(_.has(itemData, 'label') && itemData.label === '_RETURN'); - . Please fix such errors correctly a