Re: Regarding feature #6841

2024-05-16 Thread Dave Page
On Wed, 15 May 2024 at 12:33, Anil Sahoo wrote: > Hi Team, > > I have implemented the Execute query feature and tested it with different > kinds of test cases. > > FYI the PostgreSQL Do block does not work as a single statement when we > put the cursor inside the block at different positions. >

Re: Regarding feature #6841

2024-04-24 Thread Dave Page
On Wed, 24 Apr 2024 at 14:43, Thom Brown wrote: > On Tue, 23 Apr 2024 at 13:50, Dave Page wrote: > >> >> >> On Tue, 23 Apr 2024 at 12:03, Thom Brown wrote: >> >>> You've been able to do the "Select and run" thing for years. If you select text in the editor and hit the execute button,

Re: Regarding feature #6841

2024-04-24 Thread Thom Brown
On Tue, 23 Apr 2024 at 13:50, Dave Page wrote: > > > On Tue, 23 Apr 2024 at 12:03, Thom Brown wrote: > >> >>> You've been able to do the "Select and run" thing for years. If you >>> select text in the editor and hit the execute button, only the selected >>> text is sent to the server. If

Re: Regarding feature #6841

2024-04-24 Thread Anil Sahoo
Thanks for the confirmation. — *Anil Sahoo* Software Engineer www.enterprisedb.com Power to Postgres

Re: Regarding feature #6841

2024-04-24 Thread Dave Page
Hi On Wed, 24 Apr 2024 at 12:31, Anil Sahoo wrote: > Hi Dave, > > For the Point-2, Edit dropdown shows options that are one time actionable. > In place of showing the turning off highlight option in both Edit dropdown > and Preferences, we can show it only in Preferences. > > Please give your

Re: Regarding feature #6841

2024-04-24 Thread Anil Sahoo
Hi Dave, For the Point-2, Edit dropdown shows options that are one time actionable. In place of showing the turning off highlight option in both Edit dropdown and Preferences, we can show it only in Preferences. Please give your suggestion on this. Regards, Anil --

Re: Regarding feature #6841

2024-04-23 Thread Anthony DeBarros
Hi, > > On Tue, 23 Apr 2024 at 12:03, Thom Brown wrote: > > >> >> I still find the proposal somewhat unintuitive, but the foot-gun >> safeguards that have been suggested sound like any pedal injuries will >> solely be the fault of the user. >> >> >> The scenario described by Dave sounds similar

Re: Regarding feature #6841

2024-04-23 Thread Dave Page
On Tue, 23 Apr 2024 at 12:03, Thom Brown wrote: > >> You've been able to do the "Select and run" thing for years. If you >> select text in the editor and hit the execute button, only the selected >> text is sent to the server. If nothing is selected, the entire string is >> sent. This feature

Re: Regarding feature #6841

2024-04-23 Thread Thom Brown
On Tue, Apr 23, 2024, 11:49 Dave Page wrote: > > > On Tue, 23 Apr 2024 at 11:29, Thom Brown wrote: > >> On Tue, Apr 23, 2024, 09:15 Dave Page wrote: >> >>> Adding some notes below to summarise a discussion we had on this in a >>> call... >>> >>> On Mon, 22 Apr 2024 at 08:26, Aditya Toshniwal <

Re: Regarding feature #6841

2024-04-23 Thread Dave Page
On Tue, 23 Apr 2024 at 11:29, Thom Brown wrote: > On Tue, Apr 23, 2024, 09:15 Dave Page wrote: > >> Adding some notes below to summarise a discussion we had on this in a >> call... >> >> On Mon, 22 Apr 2024 at 08:26, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi

Re: Regarding feature #6841

2024-04-23 Thread Thom Brown
On Tue, Apr 23, 2024, 09:15 Dave Page wrote: > Adding some notes below to summarise a discussion we had on this in a > call... > > On Mon, 22 Apr 2024 at 08:26, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Apr 19, 2024 at 7:15 PM Aditya Toshniwal <

Re: Regarding feature #6841

2024-04-23 Thread Dave Page
Adding some notes below to summarise a discussion we had on this in a call... On Mon, 22 Apr 2024 at 08:26, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Apr 19, 2024 at 7:15 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >>

Re: Regarding feature #6841

2024-04-22 Thread Aditya Toshniwal
Hi Dave, On Fri, Apr 19, 2024 at 7:15 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Apr 19, 2024 at 7:05 PM Dave Page wrote: > >> Hi >> >> On Fri, 19 Apr 2024 at 14:32, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>>

Re: Regarding feature #6841

2024-04-19 Thread Aditya Toshniwal
Hi Dave, On Fri, Apr 19, 2024 at 7:05 PM Dave Page wrote: > Hi > > On Fri, 19 Apr 2024 at 14:32, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Apr 19, 2024 at 6:22 PM Dave Page wrote: >> >>> Hi >>> >>> On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal

Re: Regarding feature #6841

2024-04-19 Thread Dave Page
Hi On Fri, 19 Apr 2024 at 14:32, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Apr 19, 2024 at 6:22 PM Dave Page wrote: > >> Hi >> >> On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Even if you put

Re: Regarding feature #6841

2024-04-19 Thread Aditya Toshniwal
Hi Dave, On Fri, Apr 19, 2024 at 6:22 PM Dave Page wrote: > Hi > > On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >>> Even if you put the cursor on the "SELECT"? If so, that would imply the >>> parser understands the string quoting; e.g. in

Re: Regarding feature #6841

2024-04-19 Thread Dave Page
Hi On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > >> Even if you put the cursor on the "SELECT"? If so, that would imply the >> parser understands the string quoting; e.g. in this case, the Python >> multiline string. Presumably then it would also

Re: Regarding feature #6841

2024-04-19 Thread Aditya Toshniwal
Hi Dave, On Fri, Apr 19, 2024 at 4:10 PM Dave Page wrote: > > > On Fri, 19 Apr 2024 at 05:15, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Apr 18, 2024 at 8:07 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, 18 Apr 2024 at 15:26, Anil Sahoo >>>

Re: Regarding feature #6841

2024-04-19 Thread Dave Page
On Fri, 19 Apr 2024 at 05:15, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Apr 18, 2024 at 8:07 PM Dave Page wrote: > >> Hi >> >> On Thu, 18 Apr 2024 at 15:26, Anil Sahoo >> wrote: >> >>> Hi Dave, >>> We took help from Code Mirror, i.e Code Mirror gives

Re: Regarding feature #6841

2024-04-18 Thread Aditya Toshniwal
Hi Thom, On Thu, Apr 18, 2024 at 8:26 PM Thom Brown wrote: > On Thu, Apr 18, 2024, 15:26 Anil Sahoo > wrote: > >> Hi Dave, >> We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from >> the editor through a tree called syntaxTree and by using some logic we >> extracted the

Re: Regarding feature #6841

2024-04-18 Thread Aditya Toshniwal
Hi Dave, On Thu, Apr 18, 2024 at 8:07 PM Dave Page wrote: > Hi > > On Thu, 18 Apr 2024 at 15:26, Anil Sahoo > wrote: > >> Hi Dave, >> We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from >> the editor through a tree called syntaxTree and by using some logic we >> extracted

Re: Regarding feature #6841

2024-04-18 Thread Thom Brown
On Thu, Apr 18, 2024, 15:37 Dave Page wrote: > Hi > > On Thu, 18 Apr 2024 at 15:26, Anil Sahoo > wrote: > >> Hi Dave, >> We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from >> the editor through a tree called syntaxTree and by using some logic we >> extracted the statements

Re: Regarding feature #6841

2024-04-18 Thread Thom Brown
On Thu, Apr 18, 2024, 15:26 Anil Sahoo wrote: > Hi Dave, > We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from > the editor through a tree called syntaxTree and by using some logic we > extracted the statements which have semicolon in it and also added some > extra logic to

Re: Regarding feature #6841

2024-04-18 Thread Dave Page
Hi On Thu, 18 Apr 2024 at 15:26, Anil Sahoo wrote: > Hi Dave, > We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from > the editor through a tree called syntaxTree and by using some logic we > extracted the statements which have semicolon in it and also added some > extra

Re: Regarding feature #6841

2024-04-18 Thread Anil Sahoo
Hi Dave, We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from the editor through a tree called syntaxTree and by using some logic we extracted the statements which have semicolon in it and also added some extra logic to break the whole query on next of next line as empty or if

Re: Regarding feature #6841

2024-04-18 Thread Dave Page
Hi On Wed, 17 Apr 2024 at 15:08, Anil Sahoo wrote: > Hi Hackers, > > This feature is about executing a query at the cursor position. And that > query can be a one line or multiline. I have assigned a play icon button > and F5 as the keyboard shortcut for the Execute Query feature, and for >

Re: Regarding feature #6841

2024-04-17 Thread Anil Sahoo
Hi Aditya, Sounds good, I will work on this. Thanks for the suggestion. -- *Anil Sahoo* Software Engineer www.enterprisedb.com Power to Postgres

Re: Regarding feature #6841

2024-04-17 Thread Aditya Toshniwal
Hi Anil, I think the toolbar query should look like an input box. And the tooltip with a codemirror is more UI friendly. On Wed, Apr 17, 2024 at 7:38 PM Anil Sahoo wrote: > Hi Hackers, > > This feature is about executing a query at the cursor position. And that > query can be a one line or