Thanks, the patch applied.
On Thu, Jun 24, 2021 at 3:51 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> This patch introduced the server mode api test case failure, please find
> the attached patch to fix those as well as some of the old issues in the
> server mode.
> Patch
Hi,
This patch introduced the server mode api test case failure, please find
the attached patch to fix those as well as some of the old issues in the
server mode.
Patch by: Ashesh Vashi
Thanks,
Khushboo
On Thu, Jun 24, 2021 at 11:31 AM Akshay Joshi
wrote:
> Thanks, the patch applied.
>
> On W
Thanks, the patch applied.
On Wed, Jun 23, 2021 at 7:54 PM Ashesh Vashi
wrote:
> On Wed, Jun 23, 2021 at 1:22 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Ashesh
>>
>> Following are the review comments:
>>
>>- Fixed PEP8 issues.
>>
>> Done.
>
>>
>>- In "dynamic_regis
On Wed, Jun 23, 2021 at 1:22 PM Akshay Joshi
wrote:
> Hi Ashesh
>
> Following are the review comments:
>
>- Fixed PEP8 issues.
>
> Done.
>
>- In "dynamic_registry/__init__.py" decorator @classmethod used for "
>*_get*" and "*_load_modules*" methods which are actually outside of
>
Hi Ashesh
Following are the review comments:
- Fixed PEP8 issues.
- In "dynamic_registry/__init__.py" decorator @classmethod used for "
*_get*" and "*_load_modules*" methods which are actually outside of the
class. Even constructor also outside of the class.
- Remove unused imports
On Sat, Jun 19, 2021 at 1:39 AM Ashesh Vashi
wrote:
> Hi Akshay,
>
> We do have a couple of classes, which does automatic registration of the
> base classes,
> and which creates single-ton objects for these base classes, when needed.
>
> I would be working on a patch sooner, which will be using s
Hi Akshay,
We do have a couple of classes, which does automatic registration of the
base classes,
and which creates single-ton objects for these base classes, when needed.
I would be working on a patch sooner, which will be using similar
functionality for loading
the multi-factor authentication.
