Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Akshay Joshi
Thanks patch applied. On Thu, Jan 31, 2019 at 4:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Ashesh, > > The patch looks good to me. > > On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Jan 31, 2019 at 2:38 PM Aditya To

pgAdmin 4 commit: Remove hacky way to open/close the dropdown submenu

2019-01-31 Thread Akshay Joshi
Remove hacky way to open/close the dropdown submenu Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38feacd04d50bf4f0afbdb98c962a03078295a23 Author: Ashesh Vashi Modified Files -- web/pgadmin/browser/static/js/browser.js | 1

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Aditya Toshniwal
Hi Ashesh, The patch looks good to me. On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi wrote: > On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Ashesh, >> >> All works good, except one small change. Submenus should be closed if I >> press Esc

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Ashesh Vashi
On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Ashesh, > > All works good, except one small change. Submenus should be closed if I > press Esc and then reopen the menu. > Please find the updated patch to resolve the review comments. -- Thanks, As

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Aditya Toshniwal
Hi Ashesh, All works good, except one small change. Submenus should be closed if I press Esc and then reopen the menu. On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi wrote: > Hi Aditya, > > On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi As

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-30 Thread Ashesh Vashi
Hi Aditya, On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Ashesh, > > I am getting a syntax error on bundle. > After fixing that, please look into this scenario: > Using keyboard shortcuts open object menu, for eg on table node. Go to any > sub

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-21 Thread Aditya Toshniwal
Hi Ashesh, I am getting a syntax error on bundle. After fixing that, please look into this scenario: Using keyboard shortcuts open object menu, for eg on table node. Go to any submenu using keyboard and go to any submenu and press enter. Now open object menu again using keyboard shortcut, the sub

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-21 Thread Ashesh Vashi
Any update? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi wrote: > Hi Aditya/Khushboo, > > I ca

Remove hacky way to open/close the dropdown-submenu

2019-01-17 Thread Ashesh Vashi
Hi Aditya/Khushboo, I can see a hacky way to open/close the dropdown-submenu in the menu.js file. I've followed a more general way to open/close any submenu in the dropdown list, instead of just 'Objects' menu. Can you please review it, and let me know your thoughts? Let me know if you have any o