Re: Sonarqube fixes v2

Thanks, the patch was applied. On Fri, Sep 9, 2022 at 7:24 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch which fixes issue related to rule - > > 1.Use concise character class syntax > 2.Add a "break" statement or remove this "else" clause. >

Re: Sonarqube fixes

Thanks, the patch was applied. On Sat, Sep 10, 2022 at 12:25 AM Pravesh Sharma < pravesh.sha...@enterprisedb.com> wrote: > Hi, > > Attached patch contains sonarqube fix for rule ternary operators > should not be nested. > > Thanks, > Pravesh > > -- > > > > Pravesh Sh

Sonarqube fixes

Hi, Attached patch contains sonarqube fix for rule ternary operators should not be nested. Thanks, Pravesh -- Pravesh Sharma Software Engineer +91 9406461406 www.enterprisedb.com Power to Postgres

Re: Sonarqube fixes v2

Hi, Please find the attached patch which fixes issue related to rule - 1.Use concise character class syntax 2.Add a "break" statement or remove this "else" clause. 3.Replace this generic exception class with a more specific one. 4.Use a regular expression literal instead of the 'RegExp' construct

Re: Sonarqube fixes

Thanks, the patch applied On Tue, Aug 30, 2022 at 1:07 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello Team, > > Please find the attached patch which fixes around 25 sonarqube issues. > > Thanks, > Yogesh Mahajan > EnterpriseDB > -- Akshay Jo

Sonarqube fixes

Hello Team, Please find the attached patch which fixes around 25 sonarqube issues. Thanks, Yogesh Mahajan EnterpriseDB Sonarqube_fixes_v1.patch Description: Binary data

pgAdmin 4 commit: Fixed debugger issue introduce due to SonarQube fixes

Fixed debugger issue introduce due to SonarQube fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad64491a98ca165e7c509d2d84dd12149d91fdb3 Modified Files -- web/pgadmin/tools/debugger/static/js/debugger.js | 3 ++- 1 file

pgAdmin 4 commit: Fixed issues introduce by SonarQube fixes.

Fixed issues introduce by SonarQube fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa5b1d50b9722d1a96b181233c29cb7ae29edbce Modified Files -- web/pgadmin/browser/static/js/browser.js | 2 -- web/pgadmin

Re: [pgAdmin4][Patch]: SonarQube Fixes

Thanks, the patch applied. On Thu, Jan 27, 2022 at 3:31 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the Sonarqube issues which are > assigned to me. > > Thanks, > Khushboo > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | P

[pgAdmin4][Patch]: SonarQube Fixes

Hi, Please find the attached patch to fix the Sonarqube issues which are assigned to me. Thanks, Khushboo tree_sonarqube_fixes.patch Description: Binary data

Re: [pgAdmin]:SonarQube Fixes

prisedb.com> wrote: > >> Hi Hackers, >> >> Please find attached the patch for some SonarQube fixes. >> >> -- >> Thanks & Regards, >> Pradip Parkale >> Software Engineer | EnterpriseDB Corporation >> > > > -- > Thanks &

Re: [pgAdmin]:SonarQube Fixes

Hi, Please ignore my previous patch. PFA attachment of my updated patch. On Tue, Apr 20, 2021 at 1:49 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached the patch for some SonarQube fixes. > > -- > Thanks & Regards,

[pgAdmin]:SonarQube Fixes

Hi Hackers, Please find attached the patch for some SonarQube fixes. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation SonarQube.patch Description: Binary data

Re: [pgAdmin]:SonarQube fixes.

Thanks, patch applied. On Wed, Apr 7, 2021 at 4:54 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for few SonaQube Fixes. > > I have fixed the issues in the below files. > >1. foreign_key.js >2. exclusion_constraint.js >3.

[pgAdmin]:SonarQube fixes.

Hi Hackers, Please find the attached patch for few SonaQube Fixes. I have fixed the issues in the below files. 1. foreign_key.js 2. exclusion_constraint.js 3. function.js -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation SonarQube.patch Description: B

Re: SonarQube Fixes #5 Roles & Functions

Thanks, patch applied. On Wed, Mar 17, 2021 at 4:50 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch which resolves below sonar qube issues: > > For Roles: > Refactor this function to reduce its Cognitive Complexity from 21 to the > 15 allowed > Re

Re: [pgAdmin]:Patch for SonarQube fixes.

Thanks, patch applied. On Thu, Mar 18, 2021 at 2:51 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > I have fixed a few sonarQube issues.PFA patch. > >- Fts Configuration > > >1. Remove this commented-out code. > > >- Funtion > > >1. Update this functi

[pgAdmin]:Patch for SonarQube fixes.

Hi Hackers, I have fixed a few sonarQube issues.PFA patch. - Fts Configuration 1. Remove this commented-out code. - Funtion 1. Update this function so that its implementation is not identical to the one on line 51. 2. Unexpected empty method 'validate'. - Trigger func

SonarQube Fixes #5 Roles & Functions

Hi Hackers, Please find the patch which resolves below sonar qube issues: For Roles: Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed For Functions: Refactor this function to re

Re: [pgAdmin]: Patch for SonarQube fixes.

Thanks, patch applied. On Mon, Mar 1, 2021 at 4:42 PM Nikhil Mohite wrote: > Hi Akshay, > > Sorry for the inconvenience, Please find the attached patch. > > Regards, > Nikhil Mohite. > > On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi > wrote: > >> Hi Nikhil >> >> You forgot to attach the patch :)

Re: [pgAdmin]: Patch for SonarQube fixes.

Hi Akshay, Sorry for the inconvenience, Please find the attached patch. Regards, Nikhil Mohite. On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi wrote: > Hi Nikhil > > You forgot to attach the patch :) > > On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >>

Re: [pgAdmin]: Patch for SonarQube fixes.

Hi Nikhil You forgot to attach the patch :) On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Back-form (backform.pgadmin.js): > >- TypeError can be thrown as "$tabContent" might be null or undefin

[pgAdmin]: Patch for SonarQube fixes.

Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: 1. Back-form (backform.pgadmin.js): - TypeError can be thrown as "$tabContent" might be null or undefined here. 2. User Management (user_management.js): - 'self' is already declared in the upper scope. - '

pgAdmin 4 commit: Fixed API test cases failed due to SonarQube fixes.

Fixed API test cases failed due to SonarQube fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=179bac3fd08d1bce897f1d0ad284d06301e7eb62 Modified Files -- web/pgadmin/browser/server_groups/servers/databases/__init__.py | 2

Re: SonarQube Fixes #4 Database & Foreign Tables

Thanks, patch applied. On Thu, Jan 21, 2021 at 5:25 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > > > On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >>- Change the name of the funct

Re: SonarQube Fixes #4 Database & Foreign Tables

On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi wrote: > Hi Rahul > > Following are the review comments: > >- Change the name of the function 'get_pg_db_properties'. The function >returns lastsysoid and datistemplate only and I assume it is applicable for >PG/EPAS both. > > *Done!* > >

Re: SonarQube Fixes #4 Database & Foreign Tables

Hi Rahul Following are the review comments: - Change the name of the function 'get_pg_db_properties'. The function returns lastsysoid and datistemplate only and I assume it is applicable for PG/EPAS both. - Add comments for all the new functions introduce in the patch. On Thu, Jan 2

SonarQube Fixes #4 Database & Foreign Tables

Hi Hackers, Please find the attached patch which resolves the sonar qube issues relating: 1. *Foreign Tables* -*Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed.* 2. *Database* -*Refactor this function to reduce its Cognitive Complexity from 17 to t

Re: [pgAdmin]: Patch for SonarQube fixes

Thanks, patch applied. On Tue, Jan 19, 2021 at 12:58 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > Schema diff: > >- Refactor this function to reduce its Cognitive Complexity from 17 to >th

[pgAdmin]: Patch for SonarQube fixes

Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: Schema diff: - Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 44 to the 15 allowed. - Refactor this fu

Re: Patch for SonarQube fixes.

Thanks, patch applied. On Mon, Jan 18, 2021 at 11:15 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Preferences: > >- Refactor this function to reduce its Cognitive Complexity from 18 to >

Patch for SonarQube fixes.

Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: 1. Preferences: - Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. - Merge this if statement with the enclosing one. - Define a constant instead of duplicating this literal

Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed

Thanks, patch applied. On Thu, Nov 12, 2020 at 2:15 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find below attached patch which fixes: > 1. Bgprocess watcher dialog box disappearing after server is removed > 2. Removed 3 dots on Storage Manager Dialog box (S

Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed

Hi Hackers, Please find below attached patch which fixes: 1. Bgprocess watcher dialog box disappearing after server is removed 2. Removed 3 dots on Storage Manager Dialog box (Storage Manager... to Storage Manager) 3. Previous sonarqube issues carry forward in this patch. Rest I haven't got any u

Re: SonarQube Fixes #3

Hi Hackers, Minor sonar issues too fixed. Find the updated patch. On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch to fix the SonarQube code smells having > rules: > >- Refactor this function to reduce its Cognitive Complexity from 24 to >

SonarQube Fixes #3

Hi Hackers, Please find the attached patch to fix the SonarQube code smells having rules: - Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. Also, corrected one of the backup test cases which were failing in server mode. -- *Rahul Shirsat* Software Eng

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Thu, Sep 3, 2020 at 4:39 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find more fixes for the sonarqube code smells having the rule "String > literals should not be duplicated". > > Thanks, > Khushboo > > On Wed, Aug 19, 2020 at 2:27 PM Ak

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find more fixes for the sonarqube code smells having the rule "String literals should not be duplicated". Thanks, Khushboo On Wed, Aug 19, 2020 at 2:27 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < > khushboo.va...@enterprisedb.

Re: SCSS Minor SonarQube fixes

Hi Pramod, - font-family: monospace, monospace; + font-family: 'Roboto Mono', monospace; We do not use Roboto for codemirror. Please revert the change. Regarding "monospace, monospace;", this is required by firefox. On Thu, Aug 27, 2020 at 1:06 PM Akshay Joshi wrote: > Hi Aditya > > Can you

Re: SCSS Minor SonarQube fixes

Hi Aditya Can you please review the patch? On Thu, Aug 27, 2020 at 11:25 AM Pramod Ahire wrote: > Hi, > > > > Please find attached minor fixes for sonarqube, which includes changes as > below: > > > >- Removed duplicate CSS declaration >- Added proper font with font-family > > > > Pleas

SCSS Minor SonarQube fixes

Hi, Please find attached minor fixes for sonarqube, which includes changes as below: Removed duplicate CSS declaration Added proper font with font-family Please do let me know if any changes or missed. Pramod Ahire Software Engineer C: +91-020-66449600/601 D: +91-9028697679

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

Hi Akshay, Please find the updated patch attached in this email. On Wed, Aug 19, 2020 at 2:40 PM Akshay Joshi wrote: > Hi Rahul > > I have committed Khushboo's patch where she has introduced a new method > 'not_found_error_msg', so instead of creating a new constant > 'TABLE_NOT_FOUND_MSG' use

Re: [pgAdmin4][Patch] - SonarQube Fixes #2

Hi Rahul I have committed Khushboo's patch where she has introduced a new method 'not_found_error_msg', so instead of creating a new constant 'TABLE_NOT_FOUND_MSG' use self.not_found_error_msg. Also, instead of _NODE_CSS = ‘node.css’ _COLLECTION_CSS = ‘collection.css’ We can use the following: _

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > > On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> As per offline disc

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the attached updated patch. On Tue, Aug 4, 2020 at 12:10 PM Akshay Joshi wrote: > Hi Khushboo > > As per offline discussion, multiple developers declaring the constant for > the same string and error messages. To avoid that only one developer should > work on this task. > Sugge

[pgAdmin4][Patch] - SonarQube Fixes #2

Hi Hackers, Please find the attached patch to fix the SonarQube Code smells having Rule: 1. Define a constant instead of duplicating this literal "browser/css/node.css" 4 times. 2. Define a constant instead of duplicating this literal "The specified table could not be found." 10 time

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi Khushboo As per offline discussion, multiple developers declaring the constant for the same string and error messages. To avoid that only one developer should work on this task. Suggestions: - We should have a common class for Constants (which are not module specific). - For module sp

[pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the attached patch to fix the sonarqube code smells having the rule "String literals should not be duplicated". Thanks, Khushboo sonarqube_fixes.patch Description: Binary data

Re: [pgAdmin][SonarQube] Fixes for 13 rules.

Thanks, patch applied. On Mon, Aug 3, 2020 at 12:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix around 27 SonarQube related issues raised for > rules: > >1. Remove this assignment to the local variable, the value is never >

[pgAdmin][SonarQube] Fixes for 13 rules.

Hi Hackers, Attached is the patch to fix around 27 SonarQube related issues raised for rules: 1. Remove this assignment to the local variable, the value is never used. 2. Rename local variables to match the regular expression 3. Add logic to this except clause or eliminate it and rethrow

Re: Sonarqube fixes - test_utils.py

Hi Shubham The patch is not applied because the changes that you have added in the patch is already there. On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > Attached is the patch containing a fix for the SonarQube Bug in the > test_utils.py f

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Jul 15, 2020 at 12:04 PM Satish V wrote: > Hi Hackers, > > Please find the patch which fixes sonarQube issues related to variable > shadowing. > Files altered - backgird.js, backgrid.pgadmin.js > > Kindly review and share your feedback. > > Thanks, > Sathish V >

[pgAdmin4][Patch] - SonarQube Fixes

Hi Hackers, Please find the patch which fixes sonarQube issues related to variable shadowing. Files altered - backgird.js, backgrid.pgadmin.js Kindly review and share your feedback. Thanks, Sathish V variableShadowing.patch Description: Binary data

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Tue, Jul 14, 2020 at 6:34 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the more fixes for the SonarQube Code smells having Rule > "*Functions, > methods and lambdas should not have too many parameters*". > > Thanks, > Khushboo > > >

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the more fixes for the SonarQube Code smells having Rule "*Functions, methods and lambdas should not have too many parameters*". Thanks, Khushboo On Fri, Jul 3, 2020 at 2:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < > k

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Jul 8, 2020 at 3:00 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch to fix the SonarQube Code smells having > Rule "Refactor this function to reduce its Cognitive Complexity from 18 > to the 15 allowed". > > -- > *Rahul Shirsat* > Software

[pgAdmin4][Patch] - SonarQube Fixes

Hi Hackers, Please find the attached patch to fix the SonarQube Code smells having Rule "Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed". -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. event_trigger_sonar_fixes.patch Description: Binary da

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Fri, Jul 3, 2020 at 1:12 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the SonarQube Code smells having > Rule "*Functions, methods and lambdas should not have too many parameters* > ". > > In this patch, I ha

[pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find the attached patch to fix the SonarQube Code smells having Rule "*Functions, methods and lambdas should not have too many parameters*". In this patch, I have covered sql and delete functions of all the reported nodes. Thanks, Khushboo Sonar_Qube_Fixes.patch Description: Binary

Re: [pgAdmin4][Patch] SonarQube Fixes

Thanks, patch applied. On Thu, Jun 25, 2020 at 5:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the code smells having rule (PYTHON) > NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY. > > Thanks, > Khushboo > -- *Thanks & Regards*

[pgAdmin4][Patch] SonarQube Fixes

Hi, Please find the attached patch to fix the code smells having rule (PYTHON) NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY. Thanks, Khushboo sonarqube_fixes_nested_code_blocks.patch Description: Binary data