Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-09 Thread Dave Page
On Fri, Mar 9, 2018 at 4:29 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > > > On Fri, Mar 9, 2018 at 11:04 AM Dave Page wrote: > >> Hi >> >> On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello,

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-09 Thread Joao De Almeida Pereira
On Fri, Mar 9, 2018 at 11:04 AM Dave Page wrote: > Hi > > On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello, >> Definitely running single tests is something that would be great, >> specially if you are TDDing something

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-09 Thread Dave Page
Hi On Fri, Mar 9, 2018 at 3:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > Definitely running single tests is something that would be great, > specially if you are TDDing something waiting 30-40 seconds to get feedback > is a little cumbersome when the test you

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-09 Thread Joao De Almeida Pereira
Hello, Definitely running single tests is something that would be great, specially if you are TDDing something waiting 30-40 seconds to get feedback is a little cumbersome when the test you are concerned with take less then a second. In the process: 1. Write a test 2. Make the test pass 3.

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-09 Thread Dave Page
On Thu, Mar 8, 2018 at 2:22 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > Completely forgot about this python "feature"... > Attached is the fix. > Thanks, applied. > > Just as a side question, does anyone else feel the pain of wanting to run > a

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-07 Thread Khushboo Vashi
Hi Joao, In the test_start_running_query.py, 2 static methods (is_begin_required_for_sql_query and is_rollback_statement_required) of StartRunningQuery class were used directly without @patch. Due to this, in all the cases, the original value of them doesn't restore. To fix this, I have sent the

pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-02-09 Thread Dave Page
Support EXPLAIN on Greenplum. Fixes #3097 - Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them - Extract SQLEditor backend functions that start executing query to their own files and add tests around it - Move the Explain SQL from the front-end and