Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

2017-08-29 Thread Dave Page
Hi On Mon, Aug 28, 2017 at 7:51 AM, Akshay Joshi wrote: > Hi Dave > > Changes looks good to me, only one thing is that I also override > 'DATA_DIR' and 'TEST_SQLITE_PATH' parameter in my config_local.py, so we > should include both the parameters in

Re: pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-29 Thread Harshal Dhumal
Hi Ashesh, I ran feature test case on mac couple times however I didn't get failure which Dave and you got. In my case feature test cases mostly falling in xxs_debugger test case. This was because as when we configure database sever to debug functions it adds 21 its own functions in database and

Re: pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-29 Thread Dave Page
On Tue, Aug 29, 2017 at 8:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Ashesh, > > I ran feature test case on mac couple times however I didn't get failure > which Dave and you got. > In my case feature test cases mostly falling in xxs_debugger test case. > > This was

pgAdmin 4 commit: Allow pgAdmin to run with config database versions fr

2017-08-29 Thread Dave Page
Allow pgAdmin to run with config database versions from the future. Fixes #2664 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7835da267b390ce8fc97c68ca735e0e0c8bde94a Author: Surinder Kumar Modified Files

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-08-29 Thread Dave Page
Hi On Fri, Aug 25, 2017 at 2:45 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch, > - For displaying hidden files I have added preference option in Storage > section. > How painful would it be to include it on the file dialogue as well?

pgAdmin 4 commit: Cleanup feature tests. Fixes #2586

2017-08-29 Thread Dave Page
Cleanup feature tests. Fixes #2586 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ceb9438000cea77f7054693a292cf4bd5850b4a0 Author: Harshal Dhumal Modified Files --

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-08-29 Thread Surinder Kumar
Hi Ashesh, Can you please review this patch please? Thanks, Surinder On Wed, Aug 16, 2017 at 3:43 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Updated patch contains changes: > >- Enable definePlugin for development environment as well. Just adding >

Re: [pgaweb][patch] Use https link for git repo

2017-08-29 Thread Matthew Kleiman
bump. On Tue, Aug 15, 2017 at 3:58 AM Matthew Kleiman wrote: > Hi Hackers, > > As per discussion on >

Re: [pgaweb][patch] Use https link for git repo

2017-08-29 Thread Magnus Hagander
On Tue, Aug 29, 2017 at 4:45 PM, Dave Page wrote: > > > On Tue, Aug 29, 2017 at 3:30 PM, Matthew Kleiman > wrote: > >> bump. >> >> On Tue, Aug 15, 2017 at 3:58 AM Matthew Kleiman >> wrote: >> >>> Hi Hackers, >>> >>> As per discussion

Re: [pgaweb][patch] Use https link for git repo

2017-08-29 Thread Dave Page
On Tue, Aug 29, 2017 at 3:55 PM, Magnus Hagander wrote: > > > On Tue, Aug 29, 2017 at 4:45 PM, Dave Page wrote: > >> >> >> On Tue, Aug 29, 2017 at 3:30 PM, Matthew Kleiman >> wrote: >> >>> bump. >>> >>> On Tue, Aug 15, 2017 at 3:58

Re: [pgaweb][patch] Use https link for git repo

2017-08-29 Thread Dave Page
On Tue, Aug 29, 2017 at 3:30 PM, Matthew Kleiman wrote: > bump. > > On Tue, Aug 15, 2017 at 3:58 AM Matthew Kleiman > wrote: > >> Hi Hackers, >> >> As per discussion on https://www.postgresql.org/message-id/flat/CAGRPzo-_ >>