[pgAdmin4][RM#3058] Content of SQL panel is not updating properly

2018-02-01 Thread Murtuza Zabuawala
Hello, PFA patch to fix the issue where SQL panel content is not updating properly when user traverse from child to parent node in browser tree as described in the ticket. I have also fixed the similar issue for Dependencies & Dependents panel. -- Regards, Murtuza Zabuawala EnterpriseDB: http://

pgAdmin 4 commit: Significantly improve connection loss detection and h

2018-02-01 Thread Dave Page
Significantly improve connection loss detection and handling in the query tool. Fixes #2815 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e0da9c5a0cf75a3a6a2f04601caaf61d3343bfd9 Author: Harshal Dhumal Modified Files -- web/pga

pgAdmin 4 commit: Fix on-click handling of treeview nodes that wasn't r

2018-02-01 Thread Dave Page
Fix on-click handling of treeview nodes that wasn't refreshing SQL/Dependencies/Dependents in some circumstances. Fixes #3058 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ad44cb51e33349aad46714e7cc12aff5e29ce94 Author: Murtuza Zabuawala

Re: [pgAdmin4][RM#3058] Content of SQL panel is not updating properly

2018-02-01 Thread Dave Page
Thanks, applied. On Thu, Feb 1, 2018 at 11:15 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > PFA patch to fix the issue where SQL panel content is not updating > properly when user traverse from child to parent node in browser tree as > described in the ticket. >

Master-Slave error: the database system is starting up

2018-02-01 Thread Sargez
Windows Server 2012 Postgres 9.6 I made a replication with the master server. On the slave server service postgres is running, but in log files slave's server "FATAL: the database system is starting up" message will continue. when I try from the command line run the command psql.exe -U postgres`

Re: Master-Slave error: the database system is starting up

2018-02-01 Thread Murtuza Zabuawala
​This email group is related to pgAdmin development, Please consider sending your query to ​pgsql-gene...@postgresql.org On Thu, Feb 1, 2018 at 5:19 PM, Sargez wrote: > Windows Server 2012 > Postgres 9.6 > I made a replication with the master server. On the slave server service > postgres is ru

Revamped runtime vs. Version number

2018-02-01 Thread Dave Page
So there's been nothing but positive feedback about the PoC revamped runtime I asked folks on the lists to test. Thank you to everyone that did so. With that in mind, I think we should use that in the next version and moving forwards, and bump the version number to 3.0 for the next release. Does a

Fix for RM3052: Alter column error

2018-02-01 Thread Harshal Dhumal
Hi,. Issue was caused due to we were considering internal datatype length (eg. smallint 2 bytes, int4 4 bytes, integer 8 bytes) as user configurable length. However we cannot change internal datatype lengths of some primitive datatypes. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB I

Re: Revamped runtime vs. Version number

2018-02-01 Thread Melvin Davidson
Dave, I am in favor of "version number to 3.0 for the next release". Melvin Davidson 🎸 I reserve the right to fantasize.  Whether or not you wish to share my fantasy is entirely up to you. www.youtube.com/unusedhero/videos Folk Alley - All Folk - 24 Hours a day www.folkalley.com On Th

pgAdmin 4 commit: Don't include sizes on primitive datatypes that shoul

2018-02-01 Thread Dave Page
Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052 Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3424f420e738f7c2060d7b3ba79c6bbf80e570de Author: Harshal Dhumal Modified Files --

Re: Revamped runtime vs. Version number

2018-02-01 Thread Ashesh Vashi
On Feb 1, 2018 8:15 PM, "Dave Page" wrote: So there's been nothing but positive feedback about the PoC revamped runtime I asked folks on the lists to test. Thank you to everyone that did so. With that in mind, I think we should use that in the next version and moving forwards, and bump the versi

Re: Fix for RM3052: Alter column error

2018-02-01 Thread Dave Page
Thanks, applied. On Thu, Feb 1, 2018 at 2:46 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi,. > > Issue was caused due to we were considering internal datatype length (eg. > smallint 2 bytes, int4 4 bytes, integer 8 bytes) as user configurable > length. > However we cannot chan

Re: Revamped runtime vs. Version number

2018-02-01 Thread Paolo Saudin
As Melvin, I am too in favor of "version number to 3.0 for the next release". Paolo 2018-02-01 16:00 GMT+01:00 Ashesh Vashi : > > > On Feb 1, 2018 8:15 PM, "Dave Page" wrote: > > So there's been nothing but positive feedback about the PoC revamped > runtime I asked folks on the lists to test.

Re: Revamped runtime vs. Version number

2018-02-01 Thread Robert Eckhardt
On Thu, Feb 1, 2018 at 9:45 AM, Dave Page wrote: > So there's been nothing but positive feedback about the PoC revamped > runtime I asked folks on the lists to test. Thank you to everyone that did > so. > > With that in mind, I think we should use that in the next version and > moving forwards, a

Re: Revamped runtime vs. Version number

2018-02-01 Thread Dave Page
On Thu, Feb 1, 2018 at 3:17 PM, Robert Eckhardt wrote: > > > On Thu, Feb 1, 2018 at 9:45 AM, Dave Page wrote: > >> So there's been nothing but positive feedback about the PoC revamped >> runtime I asked folks on the lists to test. Thank you to everyone that did >> so. >> >> With that in mind, I

Re: Revamped runtime vs. Version number

2018-02-01 Thread Anthony DeBarros
+1 … what roughly would be the release date? (Asking only because my beginner SQL book, which uses pgAdmin, is publishing in April and we are in the final proofreads now.) Anthony DeBarros On February 1, 2018 at 10:09:46 AM, Paolo Saudin (paolosau...@gmail.com) wrote: As Melvin, I am too in fav

Re: Revamped runtime vs. Version number

2018-02-01 Thread Dave Page
On Thu, Feb 1, 2018 at 3:21 PM, Anthony DeBarros wrote: > +1 … what roughly would be the release date? (Asking only because my > beginner SQL book, which uses pgAdmin, is publishing in April and we are in > the final proofreads now.) > Maybe in a couple of weeks. I don't have a specific plan yet

pgAdmin 4 commit: Don't include sizes on primitive datatypes that shoul

2018-02-01 Thread Dave Page
Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2042f89ce03015b8deb0d264eae8552aaf378ad9 Author: Harshal Dhumal Modified Files --

Re: Master-Slave error: the database system is starting up

2018-02-01 Thread Sargez
thank you, I've just written them. But problem still is not solved... "FATAL: the database system is starting up" message will continue. -- Sent from: http://www.postgresql-archive.org/PostgreSQL-pgadmin-hackers-f2155306.html

pgAdmin 4 commit: Revert "Don't include sizes on primitive datatypes th

2018-02-01 Thread Dave Page
Revert "Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052" This reverts commit 3424f420e738f7c2060d7b3ba79c6bbf80e570de. Committed on the wrong branch :-( Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgad