Hi Dave,
As validation related patch was committed with RM#3148 [ Sorry about that I
forgot to checkout :) ]
PFA patch to fix the issues you mentioned, I have also removed extra error
message from sub node collection control and made it optional via flag.
--
Regards,
Murtuza Zabuawala
Thanks, applied.
On Tue, Feb 27, 2018 at 3:02 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the PEP-8 issues in Resource group, Roles & Tablespaces
>
> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
> servers/tablespaces/
>
Hi
On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find patch to fix wrong sql issue for time related type.
>
> Steps to reproduce:
>
> Alter any time/datetime array related data type, it generates sql with
> addition array bracket
>
>
Hi,
PFA patch to fix the issue where Tab key was not working as expected in
query tool editor.
Steps to reproduce:
1) Type any multiline sql/text.
2) select the complete sql by pressing Ctrl+A.
3) Press Tab key multiple times, you will see the problem in code
indentation.
Please review.
--
Case sensitive paths are confusing git...
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dbfd23797bf46bc27eb4d8a5a20ecc4165b9d57
Modified Files
--
.gitignore | 1 +
1 file changed, 1 insertion(+)
Thanks, applied.
On Mon, Feb 26, 2018 at 8:36 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi hackers,
> Attached you can find the correct for the bug #3150. The functions SQL tab
> stopped working after #3060, this patch changes the SQL to ensure that the
> tab is
Fix function reserve SQL for GPDB. Fixes #3150
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3be22383b81b05b8f5fb62173809e85faaac638b
Author: Joao Pedro De Almeida Pereira
Modified Files
--
Support tab navigation in dialogs. Fixes #2898
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa1849c13af7f7188c4ed0936eb22796b56a3998
Author: Harshal Dhumal
Modified Files
--
Cool - that works. Patch applied.
Thanks!
On Tue, Feb 27, 2018 at 6:30 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> On Tue, Feb 27, 2018 at 1:08 AM, Dave Page wrote:
>
>> Hi,
>>
>> I'm still able to make it get stuck, if I tab back and forth
Thanks, applied!
On Tue, Feb 27, 2018 at 7:19 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> Please find patch to fix pep-8 issues for given modules.
>
> 1. server group (__init__.py)
> 2. server (__init__.py, gpdb.py, types.py, utils.py)
>
>
> --
> *Harshal Dhumal*
>
PEP8 fixes for the server and server group modules.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=055f7abc9ed0f3b547cf1a93fac84ff3abdd14e1
Author: Harshal Dhumal
Modified Files
--
Hi
Still not quite right - see the attached screenshot which is the result of
simply viewing the properties of an existing job. Note that the start time
is shown in the grid but not the subnode control.
Thanks.
On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
Hi Dave,
Could you please send screenshot?
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote:
> Hi
>
> Still not quite right - see the attached screenshot which is the
I'm not able to re-produce the issue, Could you hard refresh and try again?
If possible could you please provide exact steps?
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Feb 27, 2018 at 5:30 PM, Dave Page
Thanks guys - patch applied.
On Mon, Feb 26, 2018 at 5:31 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Thank you Joao for reviewing.
>
> On Mon, Feb 26, 2018 at 10:43 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Murtuza,
>> We just
Add keyboard shortcuts for the Query Tool. Fixes #2900
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9de043fef964586858acb7070cbbebf2601b340
Author: Murtuza Zabuawala
Modified Files
--
Hi,
Please find patch to fix wrong sql issue for time related type.
Steps to reproduce:
Alter any time/datetime array related data type, it generates sql with
addition array bracket
[image: Inline image 1]
--
*Harshal Dhumal*
*Sr. Software Engineer*
EnterpriseDB India:
Hello Murtuza,
The patch looks good, and solves the problem. Run the patch on our CI and
everything is green.
Thanks
Joao
On Tue, Feb 27, 2018 at 8:11 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where Tab key was not working as
Thank you for testing it Joao.
--
Regards,
Murtuza
On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza,
>
> The patch looks good, and solves the problem. Run the patch on our CI and
> everything is green.
>
> Thanks
> Joao
>
> On Tue,
Hi
On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> I'm not able to re-produce the issue, Could you hard refresh and try again?
>
I still see it.
>
> If possible could you please provide exact steps?
>
Attached is a dump of my test pgagent
Thanks Dave, I'll look into it.
On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote:
> Hi
>
> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala enterprisedb.com> wrote:
>
>> I'm not able to re-produce the issue, Could you hard refresh and try
>>
Thanks, patch applied.
On Tue, Feb 27, 2018 at 3:00 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Thank you for testing it Joao.
>
> --
> Regards,
> Murtuza
>
> On Tue, Feb 27, 2018 at 8:29 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello
On Mon, Feb 26, 2018 at 9:19 PM, Dave Page wrote:
> Can you rebase this please? It doesn't apply against master.
>
> Please find the updated patch excluding utils module as it is already
done.
> On Mon, Feb 26, 2018 at 12:04 PM, Khushboo Vashi <
>
23 matches
Mail list logo