Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hi Joao It seems that this fix broke the functionality of RM #2815. It is mentioned in the RM what needs to be fixed now and I am currently working on it. While fixing the issue following problem that I found - In "start_running_query.py" file, we need to remove check "if conn.connected()"

pgAdmin 4 commit: Update Karma to 2.0 with plugins. Fixes #3222

Update Karma to 2.0 with plugins. Fixes #3222 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35b0ab2fe19a3f207dccc949ce22f48d1e045344 Author: Joao Pedro De Almeida Pereira Modified Files -- web/karma.conf.js | 11 +- web/package

Re: [pgadmin4][patch] Update karma to 2.0 #3222

Thanks, applied. On Mon, Mar 19, 2018 at 3:11 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Attached you can find the patch that updates karma to 2.0 and also other > plugins from karma. > > The only plugins that are not updated are the jasmine ones because we

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

I'm a little concerned that noone mentioned this earlier; I'm supposed to be building the release this afternoon, and I expect this change to at the very least be complex to fully test and verify. What's the ETA on the patch? What steps are being taken to ensure it's correct and doesn't cause regre

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

On Tue, Mar 20, 2018 at 3:06 PM, Dave Page wrote: > I'm a little concerned that noone mentioned this earlier; I'm supposed to > be building the release this afternoon, and I expect this change to at the > very least be complex to fully test and verify. What's the ETA on the > patch? What steps ar

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi wrote: > > > On Tue, Mar 20, 2018 at 3:06 PM, Dave Page > wrote: > >> I'm a little concerned that noone mentioned this earlier; I'm supposed to >> be building the release this afternoon, and I expect this change to at the >> very least be complex to

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hi Hackers Attached is the patch file to fix the RM #2815. On Tue, Mar 20, 2018 at 3:24 PM, Dave Page wrote: > > > On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page >> wrote: >> >>> I'm a little concern

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Thanks for doing this, sorry about the breakage. We're taking a look at this to make sure it is still working with Greenplum. -- Rob On Tue, Mar 20, 2018 at 9:12 AM, Akshay Joshi wrote: > Hi Hackers > > Attached is the patch file to fix the RM #2815. > > On Tue, Mar 20, 2018 at 3:24 PM, Dave P

pgAdmin 4 commit: 3.0 release notes

3.0 release notes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3bd9bdad614310b1a416a5f296c4863237817c84 Author: Karen Blatchley Modified Files -- docs/en_US/release_notes.rst | 1 + docs/en_US/release_notes_3_0.rst | 100 +

pgAdmin 4 commit: Fix an error on exit caused by the cookie path patch.

Fix an error on exit caused by the cookie path patch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4942c938acabedab99fb7328c16c34f7d2535702 Author: Khushboo Vashi Modified Files -- web/pgAdmin4.py | 4 +--- web/pgadmin/_

Build failed in Jenkins: pgadmin4-master-python35 #540

See Changes: [Dave Page] 3.0 release notes [Dave Page] Fix an error on exit caused by the cookie path patch. -- Started by an SCM change Started by an SCM change

Build failed in Jenkins: pgadmin4-master-python26 #668

See Changes: [Dave Page] 3.0 release notes [Dave Page] Fix an error on exit caused by the cookie path patch. -- Started by an SCM change Started by an SCM change

pgAdmin 4 commit: PEP8 fixes

PEP8 fixes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8b456d4643a35b47de006526f96f33f62e38c1d Modified Files -- web/pgAdmin4.py | 1 - web/pgadmin/__init__.py | 1 - 2 files changed, 2 deletions(-)

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hi This doesn't pass the Javascript tests for me. Please investigate ASAP: webpack: Compiled successfully. HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 152 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 153 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0

Build failed in Jenkins: pgadmin4-master-python36 #532

See Changes: [Dave Page] 3.0 release notes [Dave Page] Fix an error on exit caused by the cookie path patch. -- Started by an SCM change Started by an SCM change

Build failed in Jenkins: pgadmin4-master-python33 #539

See Changes: [Dave Page] 3.0 release notes [Dave Page] Fix an error on exit caused by the cookie path patch. -- Started by an SCM change Started by an SCM change

Build failed in Jenkins: pgadmin4-master-python33 #540

See Changes: [Dave Page] PEP8 fixes -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM chang

Build failed in Jenkins: pgadmin4-master-python36 #533

See Changes: [Dave Page] PEP8 fixes -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM chang

Build failed in Jenkins: pgadmin4-master-python35 #541

See Changes: [Dave Page] PEP8 fixes -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM chang

Build failed in Jenkins: pgadmin4-master-python26 #669

See Changes: [Dave Page] PEP8 fixes -- [...truncated 1.17 KB...] PYTHON_VERSION=2.6 [EnvInject] - Variables injected successfully. [pgadmin4-master-python26] $ /

pgAdmin 4 commit: Add some missing items to the release notes.

Add some missing items to the release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d358369ed501b00ad97f3d1d310b00e3e359d8ca Author: Karen Blatchley Modified Files -- docs/en_US/release_notes_3_0.rst | 16 +---

Build failed in Jenkins: pgadmin4-master-python26 #670

See Changes: [Dave Page] Add some missing items to the release notes. -- [...truncated 1.27 KB...] +

Build failed in Jenkins: pgadmin4-master-python36 #534

See Changes: [Dave Page] Add some missing items to the release notes. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in wo

Build failed in Jenkins: pgadmin4-master-python33 #541

See Changes: [Dave Page] Add some missing items to the release notes. -- Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] -

Build failed in Jenkins: pgadmin4-master-python27 #543

See Changes: [Dave Page] Add some missing items to the release notes. -- [...truncated 403 B...] Resetting working tree > git reset --hard # timeout=10 > git cl

Build failed in Jenkins: pgadmin4-master-python35 #542

See Changes: [Dave Page] Add some missing items to the release notes. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

Hi Hackers, We fixed the tests and refactored some of the code. All tests pass now. Attached is the reviewed patch. Sincerely, Joao and Victoria On Tue, Mar 20, 2018 at 10:05 AM, Dave Page wrote: > Hi > > This doesn't pass the Javascript tests for me. Please investigate ASAP: > > webpack: Co

Re: AttributeError

Okay, sorry I had installed the wrong dependencies. On Wed, Mar 21, 2018 at 1:51 AM, Rahul Soshte wrote: > I installed from the git source but when I am trying to run the I am > getting this > error.I am using Ubuntu 17.10.What do I do? > > AttributeError > > AttributeError: 'Babel' object has n

Re: AttributeError

Hi Rahul, Sorry for the late reply, if you still have any issue just let us know Thanks Joao On Tue, Mar 20, 2018 at 4:21 PM Rahul Soshte wrote: > I installed from the git source but when I am trying to run the I am > getting this > error.I am using Ubuntu 17.10.What do I do? > > AttributeError

Checklist before sending patch to pgAdmin4-hackers

Hello, Here is the common checklist to follow before sending patch to pgAdmin4-hackers group, 1) Get the latest pull from master branch. 2) Apply your patch and check if applies successfully on the latest code. 3) Check for PEP8 issues - activate virtual env - cd ../web - yarn run pep8 4) Run