Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 10:45 AM,

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

On Wed, Apr 4, 2018 at 9:47 PM, Dave Page wrote: > Khushboo, Murtuza, > > Can you spend some time reviewing this please? I've started playing with > it as well - the first thing that's irking me somewhat is the lack of > comments. Descriptive function names are all well and

[pgAdmin4]: Fix for RM #3248

Hi, Please find attached patch for the fix of RM #3248 - we have modified alertify confirm dialog to modal dialog. Do review it and let me know for comments. Thanks, Neel Patel RM_3248.patch Description: Binary data

pgAdmin 4 commit: Fix requirements for Python 2.6.

Fix requirements for Python 2.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b7c86da58605a7e9f474b1a9f4508d9bfc0bdff6 Author: Murtuza Zabuawala Modified Files -- pkg/pip/setup_pip.py

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 13:55 GMT+03:00 Dave Page : > Hi > > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: >> >> I've updated patch. Now I drop tests and regressions. >> >> And I added new env var: PGADMIN_LISTEN_PORT. Default value is 8080 for >> http and 8443

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>>

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 14:16 GMT+03:00 Максим Кольцов : > 2018-04-04 13:55 GMT+03:00 Dave Page : >> Hi >> >> On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов wrote: >>> >>> I've updated patch. Now I drop tests and regressions. >>> >>> And I added new

Re: [pgAdmin4][Patch] Remake Docker container packaging

On Wed, Apr 4, 2018 at 12:16 PM, Максим Кольцов wrote: > 2018-04-04 13:55 GMT+03:00 Dave Page : > > Hi > > > > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов > wrote: > >> > >> I've updated patch. Now I drop tests and regressions. > >>

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Thanks, applied. On Wed, Apr 4, 2018 at 9:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Thank you Victoria & Joao for reviewing. > PFA updated patch. > > On Wed, Apr 4, 2018 at 12:26 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi

Re: [pgAdmin4]: Fix for RM #3248

Hi Neel, Can we make the change in wrapper instead of changing every where? File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel

Jenkins build is back to normal : pgadmin4-master-python34 #548

See

Jenkins build is back to normal : pgadmin4-master-python35 #557

See

Build failed in Jenkins: pgadmin4-master-python27 #556

See Changes: [Dave Page] Fix requirements for Python 2.6. [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change Started by an SCM

pgAdmin 4 commit: SQLAlchemy stopped supporting Python 2.6.

SQLAlchemy stopped supporting Python 2.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c0cfc9f29b1e8ac1099a135ff7acf327576691fd Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Another attempt to fix the Python 2.6 deps.

Another attempt to fix the Python 2.6 deps. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a95775ae49e47fe1f289c514bb936a726010033c Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 14:18 GMT+03:00 Dave Page : > > > On Wed, Apr 4, 2018 at 12:16 PM, Максим Кольцов wrote: >> >> 2018-04-04 13:55 GMT+03:00 Dave Page : >> > Hi >> > >> > On Wed, Apr 4, 2018 at 9:46 AM, Максим Кольцов >> >

Jenkins build is back to normal : pgadmin4-master-python33 #557

See

Build failed in Jenkins: pgadmin4-master-python36 #550

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in

Re: pgAdmin 4 commit: Fix requirements for Python 2.6.

Already on it. Unfortunately this is being fine-tuned through the test infrastructure, as my Python 2.6 installation is exhibiting some weird behaviour. On Wed, Apr 4, 2018 at 2:15 PM, Neel Patel wrote: > Hi, > > Do we really require "*Flask-Security" *package to

Jenkins build is back to normal : pgadmin4-master-python33 #559

See

Build failed in Jenkins: pgadmin4-master-python26 #686

See Changes: [Dave Page] Typo fix. -- [...truncated 4.98 KB...] Collecting Flask==0.12.2 (from -r requirements.txt (line 9)) Using cached

Build failed in Jenkins: pgadmin4-master-python26 #685

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in

Build failed in Jenkins: pgadmin4-master-python35 #555

See Changes: [Dave Page] Fix requirements for Python 2.6. [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change Started by an SCM

Jenkins build is back to normal : pgadmin4-master-python34 #546

See

Build failed in Jenkins: pgadmin4-master-python33 #558

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment

Build failed in Jenkins: pgadmin4-master-python36 #552

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment

Build failed in Jenkins: pgadmin4-master-python26 #687

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in

Build failed in Jenkins: pgadmin4-master-python35 #556

See Changes: [Dave Page] Typo fix. [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change Started by an

Build failed in Jenkins: pgadmin4-master-python33 #556

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in

Jenkins build is back to normal : pgadmin4-master-python36 #551

See

pgAdmin 4 commit: Cleanup some duplication in the requirements.

Cleanup some duplication in the requirements. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1617d003cd17be0a12883c994cf1bf6acf1beb26 Modified Files -- requirements.txt | 2 -- 1 file changed, 2 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python36 #553

See

Re: [pgAdmin4][Patch] Remake Docker container packaging

Hi On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: > > So, I've fixed it. Patch attached. Now whole requirements.txt is > installed in one step, with no left-overs and incompabilities. I've committed the patch with some minor changes to avoid breaking compatibility

Build failed in Jenkins: pgadmin4-master-python27 #557

See Changes: [Dave Page] Typo fix. [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change Started by an

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> On Wed, Apr

Build failed in Jenkins: pgadmin4-master-python34 #547

See Changes: [Dave Page] Another attempt to fix the Python 2.6 deps. -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment

pgAdmin 4 commit: Update container build to use Alpine Linux and Gunico

Update container build to use Alpine Linux and Gunicorn instead of CentOS and Apache. Fixes #3246 This results in a much more slim-line container, requiring fewer resources to run. In addition, the majority of the build is now done using the Docker infrastructure, allowing for quicker rebuilds

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 8:09 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 10:45 AM,

Build failed in Jenkins: pgadmin4-master-python34 #545

See Changes: [Dave Page] SQLAlchemy stopped supporting Python 2.6. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in

Re: pgAdmin4 - Issue of unmaintained libraries

Hi Dave, On Wed, Apr 4, 2018 at 5:03 AM, Dave Page wrote: > Hi > > On Tue, Apr 3, 2018 at 9:09 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Dave, >> >> On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: >> >>> Hi >>> >>> On

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Khushboo, Murtuza, Can you spend some time reviewing this please? I've started playing with it as well - the first thing that's irking me somewhat is the lack of comments. Descriptive function names are all well and good, but sometimes a little more is needed, especially for less experienced

Re: [pgAdmin4][Patch] Remake Docker container packaging

2018-04-04 18:22 GMT+03:00 Dave Page : > Hi > > On Wed, Apr 4, 2018 at 2:46 PM, Максим Кольцов wrote: >> >> >> So, I've fixed it. Patch attached. Now whole requirements.txt is >> installed in one step, with no left-overs and incompabilities. > > > I've

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Joao, Yes it bundles latest version but I doubt that is not using it, If we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. I have tried that and I started getting jQuery related errors when trying to run query tool or when running jasmine tests. -- Regards, Murtuza Zabuawala

Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Thanks, applied. On Wed, Apr 4, 2018 at 6:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 7:23 PM, Dave Page wrote: > >> Hi >> >> Thanks - I've committed this, however, could you send me an updated >> screenshot for the

Re: [pgAdmin4][RM#3154] Update modules to latest version

Thanks, patch applied. On Tue, Apr 3, 2018 at 4:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > Reverted back jQuery version to 1.x because of SlickGrid dependancy. > Please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

Re: pgAdmin4 - Issue of unmaintained libraries

Hi On Tue, Apr 3, 2018 at 9:09 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, > > On Tue, Apr 3, 2018 at 8:32 AM Dave Page wrote: > >> Hi >> >> On Tue, Apr 3, 2018 at 1:22 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >>

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

On Wed, Apr 4, 2018 at 2:47 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Apr 3,

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool

Hi, Thank you Victoria & Joao for reviewing. PFA updated patch. On Wed, Apr 4, 2018 at 12:26 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza > > It is really good to see other patches that are just refactoring code. > > We have some suggestions: > - We are trying