Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Thu, May 3, 2018 at 12:25 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Khushboo >>>

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

On Thu, May 3, 2018 at 6:58 AM, Akshay Joshi wrote: > Hi > > On Wed, May 2, 2018 at 9:05 PM, Victoria Henry wrote: > >> Hi Akshay, >> >> Thanks for sending this updated patch. The linter and tests are all >> passing. >> >>> - utils/driver/psycopg2/server_manager.py - Do we have Unit Test

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Thu, May 3, 2018 at 7:59 AM, Ashesh Vashi wrote: > On Thu, May 3, 2018 at 12:25 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

Hi On Thu, May 3, 2018 at 2:20 PM, Dave Page wrote: > > > On Thu, May 3, 2018 at 6:58 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Wed, May 2, 2018 at 9:05 PM, Victoria Henry wrote: >> >>> Hi Akshay, >>> >>> Thanks for sending this updated patch. The linter and t

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi wrote: > Hi Khushboo > > I have reviewed your code and looks good to me. Can we change the message > from "The database name is inappropriate" to some meaningful message, so > that user should know why it is inappropriate. If user will be able to > cre

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Victoria, On Wed, May 2, 2018 at 9:20 PM, Victoria Henry wrote: > Hi Khushboo, > > Could you write tests for this change? > We don't have any tests for these utilities, so at this point not possible to write the test cases for the same. > These files are actually apart of the ACITree refacto

[pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.

Hi Hackers, PFA patch for proper error handling when connection will be lost to server. I have created a common function alertify.pgRespErrorNotify in web/pgadmin/static/js/alertify.pgadmin.defaults.js on the lines of existing function alertify.pgNotifier. The function is called in error callback

Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.

Hi On Thu, May 3, 2018 at 11:23 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch for proper error handling when connection will be lost to > server. I have created a common function alertify.pgRespErrorNotify in > web/pgadmin/static/js/alertify.pgadmin.

pgAdmin 4 commit: Fix the template loader to work reliably under Window

Fix the template loader to work reliably under Windows (fixing external tables under Greenplum). Fixes #3324 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56658a9f8e676bb287e8e191b9acca74a23fc4e1 Author: Anthony Emengo Modified Files -

Re: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item

Thanks, patch applied! On Wed, May 2, 2018 at 7:25 PM, Anthony Emengo wrote: > Forgive me but please consider the following patch instead - as it better > adheres to the python style guide. > > On Wed, May 2, 2018 at 12:43 PM Anthony Emengo wrote: > >> Hi Hackers, >> >> Please find the attached

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi On Thu, May 3, 2018 at 10:19 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> I have reviewed your code and looks good to me. Can we change the message >> from "The d